Xiyue Deng [02/Jul  6:15pm -07] wrote:
> I have identified a case that this dependency handling is required for
> correctly byte compiling transitive dependency on packages that need to
> be newer than the built-in ones. When working on magit 4.6.0, which
> requires transient 0.13 and compat 31.0, both of which are built-in
> packages but the version required is higher than the ones bundled in
> Emacs 30.2 and hence external newer packages are required. With dh-elpa
> 2.1.9, the compilation of magit fails (full log attached). The first few
> lines look like below:
>
> ,----
> | Checking /usr/share/emacs/site-lisp/elpa/magit-4.6.0...
> | Compiling /usr/share/emacs/site-lisp/elpa/magit-4.6.0/git-commit.el...
> |
> | In toplevel form:
> | git-commit.el:103:11: Error: Symbol’s function definition is void: 
> static-when
> | Compiling /usr/share/emacs/site-lisp/elpa/magit-4.6.0/git-rebase.el...
> |
> | In toplevel form:
> | git-rebase.el:75:11: Error: transient--init-suffix-key is already defined 
> as something else than a generic function
> | ...
> `----
>
> This strongly suggests that the bundled older version of compat is
> in-use which does not provide `static-when' yet.
>
> Initially I suspected that the command to do the byte compiling may be
> at fault, more specifically the use of "--quick" may cause it to ignore
> the external packages, but ruled it out after some experiments. I have
> confirmed that using dh-elpa with the simplified dependency handling
> magit 4.6.0 will succeed to byte compile.
>
> It would be good to have this reviewed and approved soon. Maybe we can
> make an experimental upload soonish for testing?

I'm not sure where it is.  Could you just post patches?

-- 
Sean Whitton

Attachment: signature.asc
Description: PGP signature

Reply via email to