Control: found -1 3.5.1+dfsg-2+deb12u1
Hi,
This bug also affects bookworm. The latest bookworm kernel update
(linux-image-6.1.0-50-amd64, version 6.1.176-1) backported the same
API change: hid_report_raw_event() gained a size_t bufsize parameter.
As a result, openrazer-driver-dkms 3.5.1+dfsg-2+deb12u1 fails to build
during the kernel's postinst, which leaves linux-image-6.1.0-50-amd64,
linux-image-amd64, linux-headers-6.1.0-50-amd64 and linux-headers-amd64
unconfigured, and every subsequent "apt upgrade" fails with:
/var/lib/dkms/openrazer-driver/3.5.1/build/driver/razerkbd_driver.c:3124:29:
error: too few arguments to function 'hid_report_raw_event'
3124 | hid_report_raw_event(hdev, HID_INPUT_REPORT, xdata,
sizeof(xdata), 0);
In file included from razerkbd_driver.c:11:
/usr/src/linux-headers-6.1.0-50-common/include/linux/hid.h:1191:5: note:
declared here
1191 | int hid_report_raw_event(struct hid_device *hid, enum
hid_report_type type, u8 *data,
| size_t bufsize, u32 size, int interrupt);
dkms: autoinstall for kernel: 6.1.0-50-amd64 failed!
run-parts: /etc/kernel/postinst.d/dkms exited with return code 11
dpkg: error processing package linux-image-6.1.0-50-amd64 (--configure)
The same fix as for trixie works: passing the buffer size as the new
4th argument in the two calls in driver/razerkbd_driver.c (lines 3124
and 3128 in the 3.5.1 source):
--- a/driver/razerkbd_driver.c
+++ b/driver/razerkbd_driver.c
@@ -3121,11 +3121,11 @@
// report key down
xdata[1] = cur_value;
- hid_report_raw_event(hdev, HID_INPUT_REPORT,
xdata, sizeof(xdata), 0);
+ hid_report_raw_event(hdev, HID_INPUT_REPORT,
xdata, sizeof(xdata), sizeof(xdata), 0);
// report key up
xdata[1] = 0x00;
- hid_report_raw_event(hdev, HID_INPUT_REPORT,
xdata, sizeof(xdata), 0);
+ hid_report_raw_event(hdev, HID_INPUT_REPORT,
xdata, sizeof(xdata), sizeof(xdata), 0);
}
With this change the DKMS module builds and the four modules (razerkbd,
razermouse, razerkraken, razeraccessory) install fine on 6.1.0-50-amd64.
For a proper stable update this would need the same LINUX_VERSION_CODE
guard as proposed for trixie, adjusted to KERNEL_VERSION(6, 1, 176),
so the package still builds against older bookworm kernels.
Since this breaks kernel upgrades on stable for anyone with openrazer
installed, it would be great to see this fixed in a bookworm point
release.
System: Debian 12 (bookworm), kernel 6.1.0-50-amd64 (6.1.176-1),
openrazer-driver-dkms 3.5.1+dfsg-2+deb12u1.
Regards,
Oleg
