Hi Adrian,
On 7/9/26 14:42, Adrian Bunk wrote:
Control: severity -1 normal
Hi Christoph,
I've uploaded the package from mentors to unblock testing transition,
but let's keep this bug open as reference that some improvement to
the autopkgtest would be possible without huge effort.
Thank you for the review and for sponsoring 0.17.1-2.
I have implemented the suggested follow-up. `stimfit -h` now prints
usage information and exits with status 0, while invalid options still
return a nonzero status:
https://github.com/neurodroid/stimfit/commit/7b28c1dd
The Debian autopkgtest now runs `xvfb-run -a stimfit -h` and checks both
the exit status and usage output. It no longer uses `|| true` or
`allow-stderr`:
https://github.com/neurodroid/stimfit/commit/8cbe8e07
Because of my limited resources (mainly time and expertise) and because
these changes do not affect Stimfit's core functionality, I used an LLM
to implement the changes. I reviewed the resulting changes and verified
them by compiling Stimfit, testing the help and invalid-option exit
statuses under Xvfb and running the Debian packaging checks.
The fix is recorded in an 0.17.2-1 UNRELEASED changelog entry with
"Closes: #1140597". Since 0.17.1-2 has already migrated successfully, I
suggest including the changes with the next upstream release.
Let me know if you have any further concerns or suggestions.
Best wishes
Christoph
On Tue, Jun 23, 2026 at 04:14:55PM +0300, Adrian Bunk wrote:
On Tue, Jun 23, 2026 at 10:32:45AM +0200, Christoph Schmidt-Hieber wrote:
Dear Adrian,
this bug has already been fixed in 0.17.1-2, which is waiting for sponsorship
on Debian mentors.
https://mentors.debian.net/package/stimfit/
The failing test tried to run `stimfit --help`, which initializes the wx/GTK
application and therefore fails in the headless ci.debian.net environment.
...
This could be fixed by running inside xvfb-run.
The bigger problem is that "stimfit -h" returns 255,
which is likely the reason why "|| true" was added,
which would make the test pass despite certain errors.
If "stimfit -h" would return 0, then
xvfb-run -a stimfit -h
should work as autopkgtest.[1]
Best wishes,
Christoph
cu
Adrian
[1] needs a xvfb test dependency, and might also need an allow-stderr
autopkgtest restriction
