Hello Martin-Éric,
On 15/07/2026 12:34, Martin-Éric Racine wrote:
ti 14.7.2026 klo 17.00 Sylvain Beucler ([email protected]) kirjoitti:
On 14/07/2026 15:19, Martin-Éric Racine wrote:
- Please explain how you tested the update.
See Bug#1141987. I don't have any Bullseye host left, but the fixes
are one-character changes that have been verified to boot on Bookworm
and Trixie.
I believe this needs an actual test, too many times I've seen updates
that shouldn't fail, do fail -_-
You can run a bullseye VM and do some manual tests.
Please note that dhcpcd5 hadn't seen any update in ages. Version
7.1.0-2 was uploaded many Debian releases before Bullseye and left
unattended until I took over maintenance just before Bookworm, renamed
it dhcpcd and packaged the latest upstream.
Given this, two of the autopkgtest targets didn't work. One was easily
fixed, while the other fails because it expects features that haven't
been offered by the dependency for a while, so I marked it FLAKY.
Additionally, Salsa CI only ran trivial tests, due to lack of
'isolation-machine' support:
https://salsa.debian.org/debian/dhcpcd/-/pipelines/1129013
https://salsa.debian.org/debian/dhcpcd/-/jobs/9954999
We only need isolation-machine to perform consecutive installations of
mutually-exclusive NTP daemons and test that our exit hooks correctly
pass DHCP-provided NTP servers to the daemon. DHCP is not tested
per-se. However, _all_ of our NTP hook tests would fail if we couldn't
fetch an IP via DHCP. Here, only one NTP test fails for the above
reason.
We have some docs for testing locally with autopkgtest:
https://lts-team.pages.debian.net/wiki/TestSuites/autopkgtest.html#full-vm-environment-isolation-machine
Which only works until Bookworm. Qemu stalls at the login prompt in
Trixie and later (bug already filed). Anyhow, Bullseye still works,
which is how I was able to test and fix those autopkgtest targets as
above.
chrony-ntp-servers-from-dhcp FLAKY non-zero exit status 2
timesyncd-ntp-servers-from-dhcp PASS
ntpd-ntp-servers-from-dhcp PASS
openntpd-ntp-servers-from-dhcp PASS
sbin-dhcpcd-exists-without-usrmerge PASS
sbin-dhcpcd-exists-with-usrmerge PASS
qemu-system-x86_64: terminating on signal 15 from pid 250471 (/usr/bin/python3)
We're now up to the attached debdiff. Are we good with this one?
That sounds good.
(Indeed there appears to be tons of issues around autopkgtest-qemu, I
can't run my October bullseye VM anymore ("not a bootable disk"), I
can't rebuild it (grub dpkg issues), and there are currently issues with
incus-vm in debusine.)
I believe you are not a DD, so I'll need to sponsor your upload.
Do you have a text for the DLA announcement?
Cheers!
Sylvain Beucler
Debian LTS Team
