Hi Yoshiki,

Xiyue Deng <[email protected]> writes:

> Hi Yoshiki,
>
> Xiyue Deng <[email protected]> writes:
>
>> Hi Yoshiki,
>>
>> Yoshiki Obinata <[email protected]> writes:
>>
>>> Hi Xiyue,
>>>
>>> Thank you. I was busy with my Ph.D defense and my new work.
>>
>> I hope everything went smoothly :)
>>
>>> Now I can work on this, so I uploaded it like
>>> https://mentors.debian.net/package/pangu-spacing/ .
>>>
>>> Please check.
>>
>> Thanks! Left a few comments there which are mostly minor issues.
>>
>
> It looks like you have updated the package last week, and I just noticed
> it now.
>
> I tried to build the package, however the test are failing. The full
> build log using sbuild with a sid unshare can be found at [1]. Can you
> try to reproduce and fix it?
>

On further checking the issues look a bit more involved, so I took some
time to work on the fixes, which I have reported upstream:

https://github.com/coldnew/pangu-spacing/pull/49
https://github.com/coldnew/pangu-spacing/pull/50

Can you try to cherry-pick those patches and incorporate them using
`gbp-pq'? I think this is a good opportunity to get familiar with this
tool, which will help you with maintaining patches in future.

> (FYI, you can take a look at [2] for how to set up sbuild and a sid
> unshare environment. It's a bit long, but you only need to check out the
> "Setup" and "Building packages" sections for now :)
>
> [1] https://paste.debian.net/hidden/bde0ace8
> [2] https://wiki.debian.org/sbuild
>
>>>
>>> Yoshiki Obinata
>>>
>>> 2026/04/25 5:58、Xiyue Deng <[email protected]>のメール:
>>>
>>> Hi Yoshiki,
>>>
>>> Xiyue Deng <[email protected]> writes:
>>>
>>> Hi Yoshiki,
>>>
>>>
>>> Yoshiki Obinata <[email protected]> writes:
>>>
>>>
>>> Hi Xiyue,
>>>
>>>
>>> Obinata-san, please feel free to change it back to "pangu-spacing" if
>>>
>>> you prefer, and sorry for the trouble.
>>>
>>>
>>> I don't have any strong opinion to add emacs- prefix or not. Anyway, I
>>>
>>> switched back to pangu-spacing. Please check.
>>>
>>>
>>> Best regards,
>>>
>>>
>>>
>>> I saw that the project has now been moved under emacsen-team on Salsa.
>>>
>>> I have left a few comments on your commit.  Let me know if you have any
>>>
>>> questions.
>>>
>>>
>>>
>>> Sorry for the long delay. I have recently become DD and would like to
>>> sponsor your package. I have left a few minor comments (e.g. new
>>> standards version) but the package is mostly ready.
>>>
>>> Can you build it and upload to mentors.debian.net? Instructions can be
>>> found at [1]. Once that's done I'll try to uploaded.
>>>
>>> Thanks for working on this!
>>>
>>> [...]
>>>
>>>
>>> [1] https://mentors.debian.net/intro-maintainers/

-- 
Regards,
Xiyue Deng

Attachment: signature.asc
Description: PGP signature

Reply via email to