Control: tags -1 + patch
On Thu, 16 Jul 2026 at 14:01:56 -0500, Elizabeth Figura wrote:
On Thursday, 16 July 2026 06:18:26 CDT Simon McVittie wrote:
Before 2.0, in practice the test suite probably wasn't run at all,
because Mesa GL/Vulkan drivers weren't installed - so this test failure
might not actually be a regression.
I would assume so, unless someone can confirm the test was run before.
I confirm that the test was *not* run before. In the build log
https://buildd.debian.org/status/fetch.php?pkg=vkd3d&arch=ppc64el&ver=1.2-15%2Bb3&stamp=1768648399&raw=0
the tests appear to have passed, but actually if you look at the
individual .log files (which unfortunately are not available in older
buildd logs) you'll see that most (all?) tests were skipped because
there was no working Vulkan driver. This can be reproduced by rebuilding
1.2-15 in a sid chroot on the ppc64el porterbox, platti.
A build-dependency on Vulkan and GL drivers was added in
https://salsa.debian.org/wine-team/vkd3d/-/commit/d2dcaf91440111271a285b119d2a05ba8409a8b6
with the result that most of the tests are now run (under
llvmpipe/lavapipe).
If that's the case, then perhaps
these three test-cases should be ignored/marked as "todo" on ppc64el for
now?
Probably, yes. Interesting that it fails with llvmpipe on a specific
architecture, but for floating point corner cases it makes sense.
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/2139 or the
attached patch successfully works around this (confirmed on platti).
smcv
>From bd6846fa77fe4108b9d3ccbb8f844f30362b24f7 Mon Sep 17 00:00:00 2001
From: Simon McVittie <[email protected]>
Date: Fri, 17 Jul 2026 13:33:16 +0100
Subject: [PATCH 4/4] tests/d3d12: Mark some NaN corner-cases as expected to
fail on ppc64el
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=60024
Bug-Debian: https://bugs.debian.org/1142192
Signed-off-by: Simon McVittie <[email protected]>
Forwarded: https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/2139
---
tests/d3d12.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/tests/d3d12.c b/tests/d3d12.c
index e9197f1c..6e5e5f16 100644
--- a/tests/d3d12.c
+++ b/tests/d3d12.c
@@ -8510,6 +8510,14 @@ static void test_bundle_state_inheritance(void)
destroy_test_context(&context);
}
+#ifdef __powerpc64__
+ /* Some NaN corner cases don't work on ppc64el with Mesa lavapipe,
+ * https://bugs.winehq.org/show_bug.cgi?id=60024 */
+# define ON_POWERPC64 true
+#else
+# define ON_POWERPC64 false
+#endif
+
static void test_shader_instructions(void)
{
struct named_shader
@@ -10682,12 +10690,12 @@ static void test_shader_instructions(void)
{&ps_sat, {{ 0.0f, 1.0f, 2.0f, 3.0f}}, {{0.0f, 1.0f, 1.0f, 1.0f}}},
{&ps_sat, {{-0.0f, -1.0f, -2.0f, -3.0f}}, {{0.0f, 0.0f, 0.0f, 0.0f}}},
- {&ps_sat, {{ NAN, -NAN, INFINITY, -INFINITY}}, {{0.0f, 0.0f, 1.0f, 0.0f}}},
+ {&ps_sat, {{ NAN, -NAN, INFINITY, -INFINITY}}, {{0.0f, 0.0f, 1.0f, 0.0f}}, .is_mesa_bug = ON_POWERPC64},
{&ps_min_max, {{0.0f}, { 1.0f}}, {{ 0.0f, 1.0f}}},
{&ps_min_max, {{0.0f}, { -1.0f}}, {{ -1.0f, 0.0f}}},
- {&ps_min_max, {{ NAN}, { 1.0f}}, {{ 1.0f, 1.0f}}},
- {&ps_min_max, {{0.0f}, { NAN}}, {{ 0.0f, 0.0f}}},
+ {&ps_min_max, {{ NAN}, { 1.0f}}, {{ 1.0f, 1.0f}}, .is_mesa_bug = ON_POWERPC64},
+ {&ps_min_max, {{0.0f}, { NAN}}, {{ 0.0f, 0.0f}}, .is_mesa_bug = ON_POWERPC64},
{&ps_min_max, {{0.0f}, { INFINITY}}, {{ 0.0f, INFINITY}}},
{&ps_min_max, {{1.0f}, { INFINITY}}, {{ 1.0f, INFINITY}}},
{&ps_min_max, {{0.0f}, {-INFINITY}}, {{-INFINITY, 0.0f}}},
--
2.53.0
