Control: tags -1 + moreinfo Hello Jonaz,
Thanks for the quick followup! Rainy days do indeed make for good FOSS days. ;) I have reviewed the package again, and just have a few minor comments, the first of which unfortunately is blocking: - In appstream-metadata-license.patch I see you corrected the license entry. If I didn't know any better, this looks suspicious, simply because you have "Forwarded" set to "not-needed" and this is a license change. You are upstream, so the best way to handle this in my opinion would be to make the change in an upstream commit and link to it in the patch header, or make a new release entirely. I don't want to confuse the Debian DFSG Team. :) (see https://dep-team.pages.debian.net/deps/dep3/ if you haven't already.) - I would recommend strengthening your upstream metadata file, there are tons of options: https://dep-team.pages.debian.net/deps/dep12/ - In the copyright file, since you're upstream, you can just have one stanza for your copyright instead of one for * and one for debian/*. - Since you're upstream, please upstream the manpage. Otherwise, this package looks much better. Let me know if you have further questions, and please remove the moreinfo tag once you have another iteration ready. Best regards, Simon Quigley [email protected] On July 22, 2026 7:19:45 AM CDT, Thern AI Solutions <[email protected]> wrote: >Control: tags -1 - moreinfo > >Hello Simon, hope you're having a great summer so far! Raining here in Sweden, >so a perfect time to do some FOSS work :) > >moraine 0.2.1-1 is now on mentors, and I owe you a small confession: when I >wrote last time that all five points were done, they were done in my head and >in my working copy, but they never made it into the package sitting on >mentors. You were reviewing the old one. Sorry about that. This time I checked >the uploaded source instead of trusting my own memory. I'm still VERY new to >this, but loving every minute of developing this beauty! > >What is actually in this upload: > >- debian/changelog is a single "Initial release. (Closes: #1141131)" entry. >- debian/copyright says "Expat" instead of "MIT". >- Standards-Version is 4.7.4, and Priority and Rules-Requires-Root are gone. >- debhelper-compat is 14, plus dh-sequence-single-binary, which dh asks for >explicitly in compat 14. >- debian/watch is the version 5 deb822 format. > >Your build log was the most useful part of the review, so thank you for >attaching it. It turned out there were two crates that are not in Debian, and >cargo resolves both of them even though neither is ever compiled here: > >- ksni, the system-tray icon. debian/rules now builds with >--no-default-features --features gui, so the tray is simply left out. The GUI >already has a #[cfg(not(feature = "tray"))] path for platforms without a tray, >so nothing else changes. >- winresource, a Windows-only build-dependency that build.rs uses under >#[cfg(windows)] to embed the icon into the .exe. Cargo resolves >target-specific dependencies for every target, not just the host, so it broke >the Linux build even though it is never built. Removed with a quilt patch. > >It now builds cleanly with sbuild in a sid chroot, and lintian is quiet. > >dget -x >https://mentors.debian.net/debian/pool/main/m/moraine/moraine_0.2.1-1.dsc > >I am still learning this as I go, so I really do appreciate you taking the >time. Removing the moreinfo tag with this mail, and I am around if you spot >anything else. > >Best regards, >Jonaz Thern > >On 7/22/26 13:39, Simon Quigley wrote: >> Hello, >> >> Thanks for the update here. It seems like you've addressed most of or all of >> the points. >> >> Could you please remove the moreinfo tag once a new version is on Mentors? >> >> Thanks, >> Simon >> >> >> On July 17, 2026 3:58:09 PM CDT, Thern AI Solutions <[email protected]> wrote: >> >> Hello Simon, and thanx for contacting me. First of all, sorry for >> the late reply. 3 kids, 2 jobs (1 wich is my own business) and a >> hours takes alot of time, and Moraine is something I enjoy working >> on whenever I get a few hours for myself. Thank you so much for >> taking the time to go through this in such detail. I'm still >> fairly new to Debian packaging and learning something new with >> every round of feedback, so this is genuinely a big help to me. >> I've addressed all five points: 1. Changelog Collapsed it down >> to a single initial entry and corrected the version to 0.2.0-1 — I >> hadn't realised a first upload should just be one "Initial >> release" entry rather than carrying the whole history. 2. >> Copyright / license name Renamed the license from "MIT" to >> "Expat" in debian/copyright. Good learn that Expat is the correct >> name for this exact license text in Debian. 3. Standards-Version >> and control fields Bumped Standards-Version to 4.7.4 and >> dropped both Rules-Requires-Root: no and Priority: optional from >> the source stanza. 4. debhelper compat Upgraded to >> debhelper-compat 14. 5. Watch file Upgraded to version 5. I >> learned along the way that v5 is a new deb822-style format rather >> than just a version-number bump, so I rewrote it with the >> Version/Source/Mode/Matching-Pattern fields (still tracking the >> git tags). All five are done in the packaging. I'll give it a >> final lintian run in a clean unstable chroot and upload the >> corrected 0.2.0-1 to mentors. Please let me know if there's >> anything else I should fix — I really appreciate the guidance. >> Thanks again, Jonaz On 7/14/26 23:18, Simon Quigley wrote: >> >> Control: tags -1 +moreinfo Hello, Thank you for your work >> here. A few things: - Please only keep one changelog entry, >> the initial one, with a corrected version. The additional >> changelog entries are not needed. - In the license file, it is >> expected to use the license name "Expat" instead of "MIT," >> please fix that. - Please update Standards-Version to 4.7.4, >> dropping Rules-Requires-Root: no and Priority: optional. - >> Please consider upgrading to debhelper-compat 14. - Please >> upgrade the watch file to version 5. I also can't get it to >> build, see the attached log. If this is a Rust package, you >> might want to include it in the debcargo-conf monorepo >> following their docs: https://rust-team.pages.debian.net/book/ >> Please remove the moreinfo tag once you're ready for another >> review. Feel free to CC me, if I'm available I can re-review. >> Best regards, Simon Quigley [email protected]
