On 26/07/26 4:46 pm, Nilesh Patra wrote:
>
>
> On 26/07/26 4:01 pm, Nilesh Patra wrote:
>> Hi Arnaud, Banjamin,
>>
>> On 29/06/26 1:51 pm, Arnaud Rebillout wrote:
>>> Package: lintian
>>> Version: 2.137.1
>>> Severity: normal
>>> User: [email protected]
>>> Usertags: origin-kali
>>>
>>> Dear Maintainer,
>>>
>>> For as long as I've been a Kali Linux maintainer (so that's 5 years
>>> now), I've been used to see (and to ignore) these Lintian warnings:
>>>
>>> ```
>>> I: base-files source: adopted-extended-field (in section for source)
>>> XS-Debian-Vcs-Browser [debian/control:12]
>>> I: base-files source: adopted-extended-field (in section for source)
>>> XS-Debian-Vcs-Git [debian/control:11]
>>> I: base-files source: adopted-extended-field (in section for source)
>>> XSBC-Original-Maintainer [debian/control:4]
>>> ```
>>>
>>> For background, these fields are commonly used in Debian derivatives, we
>>> use it to keep track of the original values. You might want to refer to
>>> Lintian commits:
>>> * aeea7148d5f3ea18f449cbb05bde8d982e6698ff
>>> * 754d945fb87feea18b6d12c47e2ce280597dd9ac
>>>
>>> I never understood why Lintian thinks those fields have been adopted
>>> though. If I try to rename it to drop the XS- and XSBC- prefixes, then
>>> it's dpkg-source that complains:
>>>
>>> ```
>>> dpkg-source: warning: unknown information field 'Original-Maintainer' in
>>> input data in source package stanza of template control file
>>> dpkg-source: warning: unknown information field 'Debian-Vcs-Git' in input
>>> data in source package stanza of template control file
>>> dpkg-source: warning: unknown information field 'Debian-Vcs-Browser' in
>>> input data in source package stanza of template control file
>>> ```
>>
>> I don't understand the dynamics of control file fields in downstream
>> distributions well enough, but my reading of the code suggests
>> that the fields added in the commits you mention are only partial, it should
>> also instead the XS{,BC} prefixes.
>>
>> This patch below should fix these lintian info tags. Could you give it a
>> try? Would you also be able to run entire autopkgtest lintian testsuite
>> for Kali/Ubuntu and let me know if there are more regressions?
>>
>> I'd also assume that rest of the fields mentioned below also need "XS-"? Let
>> me know - otherwise, if you could come up with a patch for the remaining
>> fields as well, feel free to send an MR my way.
>>
>>
>> diff --git a/data/common/source-fields b/data/common/source-fields
>> index 141b69875..4ef9296cb 100644
>> --- a/data/common/source-fields
>> +++ b/data/common/source-fields
>> @@ -19,11 +19,11 @@ Checksums-Sha256
>> # NB: Do not rely on @if-vendor-is-not in your data files; it may
>> # disappear without notice
>> @if-vendor-is-not debian Debian-Vcs-Arch
>> -@if-vendor-is-not debian Debian-Vcs-Browser
>> +@if-vendor-is-not debian XS-Debian-Vcs-Browser
>> @if-vendor-is-not debian Debian-Vcs-Bzr
>> @if-vendor-is-not debian Debian-Vcs-Cvs
>> @if-vendor-is-not debian Debian-Vcs-Darcs
>> -@if-vendor-is-not debian Debian-Vcs-Git
>> +@if-vendor-is-not debian XS-Debian-Vcs-Git
>> @if-vendor-is-not debian Debian-Vcs-Hg
>> @if-vendor-is-not debian Debian-Vcs-Mtn
>> @if-vendor-is-not debian Debian-Vcs-Svn
>> @@ -48,7 +48,7 @@ Origin
>> #
>> # NB: Do not rely on @if-vendor-is-not in your data files; it may
>> # disappear without notice
>> -@if-vendor-is-not debian Original-Maintainer
>> +@if-vendor-is-not debian XSBC-Original-Maintainer
>>
>> Package-List
>> Rules-Requires-Root
>
> Oh well, no, this is going to lead to "unknown-field". #1013414 is related.
> The check needs fixing here instead.
OK, I have attempted to fix this in
https://salsa.debian.org/lintian/lintian/-/merge_requests/767
The test should be tried with this MR and the patch pasted above both. Also
please let me know which of these fields need prefixing and what prefix (XS?
XC? XB? ...)
MR welcome, ofcourse.
