Hi Tobi,
Thank you very much for the review, I've addressed everything you pointed out:
- tinywl: verified that it's not used (examples=false excludes it
already anyway), so re-packaged it as Files-Excluded in
debian/copyright.
- d/copyright: changed MIT to Expat, dropped the Comment in that
stanza, and dropped the CC0-1.0 stanza and text completely since
we don't ship tinywl anymore (so the double negative in wording
is irrelevant anymore, but I'll keep this in mind for the future).
- d/control: removed Rules-Requires-Root, and reduced the
Standards-Version to 4.7.4. Also, I went through each versioned
Build-Depends requirement and checked it directly against
bookworm (oldstable) -- none of them are actually satisfied
there (like libwayland-dev is 1.21.0 while mine is >= 1.24.0,
and meson is 1.0.1 while mine is >= 1.3), so I didn't change
those.
- d/changelog: squashed into a single entry.
- d/*.install: switched to ${DEB_HOST_MULTIARCH}.
- Examples: created debian/libscenefx-0.5-dev.examples so that
examples/scene-graph.c ships using dh_installexamples in the -dev
package.
- SONAME warning: it turns out that upstream's meson build doesn't
set a soversion, so there was only one output file
libscenefx-0.5.so and no unversioned symlink. Created .links file
so that -dev ships libscenefx.so
I also dropped the redundant Priority field and bumped debhelper-compat to 14.
I pushed everything to the salsa repo and reuploaded onto debian mentors. Once
again, thank you for the feedback. I hope to hear from you again!
Best regards,
Damian
