Dear Debian Hamradio maintainers,
I am writing about the pre-removal warning for src:fbb (bug #1147109),
and about the release-critical bug that triggered it, #1091298 (FTBFS on
armhf: satupdat.c, "passing argument 1 of 'time' from incompatible
pointer type").
First, a disclosure: I am not the current maintainer of LinFBB. The
maintainer of record, as listed in the AUTHORS file and in configure.ac
of the sources, is Dave van der Locht.
However, the code affected by #1091298 (satupdat and ajoursat) is code I
wrote, and I did not want to see the package removed from Debian because
of it.
I therefore felt obliged to fix it, and to publish a new upstream
release containing the recent corrections. I hope this is welcome.
LinFBB 7.0.12 is now published:
- Source tarballs fbb-7.0.12.tar.gz and fbb-7.0.12.tar.bz2 are in the
root of the Files area of the linfbb project on SourceForge, next to
fbb-7.0.11.tar.gz.
Their names match the existing debian/watch pattern; with the current
uversionmangle rule, uscan should report the version as 7.012.
- The SVN tag is tags/7.0.12 (revision 259, copied from trunk revision
258).
SHA-256 checksums:
43c8189000d617d7618608db362466b37053da373e1c89d3f10ecb31f7d1a410
fbb-7.0.12.tar.gz
23050ae7537c58876641c6bdcaa24cd522a98354db5970d9a9b9d04d73e02d77
fbb-7.0.12.tar.bz2
About #1091298: the variables passed to time() in satupdat.c and
ajoursat.c are now declared as time_t instead of long (the fix has been
in trunk since revision 241, well before this release).
The armhf failure came from time_t being 64-bit while the variable was a
32-bit long. I could test the patch on RaspBerry Pi armhf with OS 32 bit
myself.
The tarball builds cleanly from a fresh configure && make on amd64 with
GCC 15.2.
Other changes since 7.0.11, for the changelog: satel.dat is no longer
created with mode 0700 by satupdat/ajoursat; support for the Alpha-5
satellite catalogue numbers (NORAD numbers of 100000 and above); a fix
for an undefined-behaviour call in crcdix(); xfbbC documentation fixes;
and the build time added to the xfbbd/xfbbC banners. The full list is in
the ChangeLog of the tarball.
The existing Debian patches (for example 02-remove-SVNREV and
08-statedir) may need to be refreshed against 7.0.12.
Would it be possible to update the package to 7.0.12? If so, this should
close #1091298, and the removal request in #1147109 would no longer apply.
In the meantime, could the removal be put on hold? I am happy to help
with testing or with any change needed on the upstream side.
Thank you for your time and for maintaining fbb in Debian.
Best regards,
Bernard Pidoux, F6BVP / AI7BG
[email protected]
