The Debian NEW review of dart-node-preamble 2.0.2-1 has been completed. Decision: ACCEPTED Reviewer: Andrew McMillan
Review comment: Hi, Issues found ============ 1. Pre-built/minified JS shipped but not rebuildable in Debian (quality/reproducibility, borderline DFSG). lib/preamble.min.js and the embedded minified string in lib/preamble.dart are generated by terser (see tool/minify.js, package.json, yarn.lock). terser is not a Build-Depends in debian/control and is not available in Debian, so debian/rules (dh $@ only) ships upstream's prebuilt artifacts without regenerating them. The debian/source/lintian-overrides suppresses source-contains-prebuilt-javascript-object on the grounds that the unminified lib/preamble.js is present as the preferred form of modification. That justification is valid, so this is not a DFSG violation — but it does mean the shipped minified output can't be reproduced from source during the Debian build. 2. debian/copyright's blanket dual-license is imprecise. Files: * → License: Expat and BSD-3-clause asserts every file is under both licenses. In reality the two grants come from different copyright holders (LICENSE): the Dart-derived BSD code vs. Bullington's MIT work. A more accurate document would split or annotate the Dart-derived portion of lib/preamble.js/lib/preamble.dart as BSD-3-clause and note Bullington's additions as Expat. Not a DFSG problem, but a documentation-precision issue. 3. Shipped source files carry no license/copyright headers. lib/preamble.js, lib/preamble.dart, and lib/preamble.min.js have no header; all attribution lives only in the top-level LICENSE (which is not itself installed by debian/install — coverage relies on the auto-installed debian/copyright). 4. debian/install ships preamble.min.js into the binary package. lib usr/share/dart/packages/node_preamble/ installs the minified file wholesale. Acceptable given the override, but worth confirming consumers actually need it. Thanks! Full review details: https://dfsg-new-queue.debian.org/reviews/dart-node-preamble
