The Debian NEW review of python-libsoundtouch 0.8.0-1 has been completed. Decision: ACCEPTED Reviewer: Andrew McMillan
Review comment: Hi, Th epackage is accepted, but there are a few pedantic packaging quality issues 1. nodoc build profile is declared but not honoured in debian/rules debian/control guards the Sphinx/doc build-deps with <nodoc> (python3-sphinx, python3-requests, python3-websocket, python3-zeroconf), but override_dh_auto_build in debian/rules:7-10 runs dh_doc_privacy and sphinx-build unconditionally. Building with the nodoc profile (DPKG_BUILD_PROFILES=nodoc) would therefore try to invoke Sphinx even though python3-sphinx is not installed, and fail. The Sphinx build and dh_doc_privacy should be guarded with $(filter nodoc,$(DEB_BUILD_PROFILES)). 2. dh_doc_privacy is run on source before building, so it likely misses the shipped HTML debian/rules:9 runs dh_doc_privacy README.md docs against the source tree, before sphinx-build. The privacy-violating content that matters is in the generated HTML: the remote ghbtns.com iframe in docs/_templates/sidebarintro.html:2 (copied verbatim into the built page) and the remote Travis/Coveralls/PyPI badge image:: directives in docs/index.rst:9-16. Since Sphinx re-embeds these into _build/html, sanitizing the source .rst/template beforehand won't reliably clean the shipped docs. dh_doc_privacy is normally a debhelper sequence step operating on the built docs. 3. Redundant/conflicting docs installation debian/python3-libsoundtouch.docs:2 lists docs/_build/html, while dh-sequence-sphinxdoc (debian/control:11) is also enabled. dh_sphinxdoc installs the Sphinx HTML output to /usr/share/doc/python3-libsoundtouch/html and registers it with doc-base itself, so the same tree is being installed twice via two mechanisms. This should be one or the other. 4. dh_auto_build $@ --buildsystem=pybuild passes the target name to the build system In debian/rules:8, $@ expands to override_dh_auto_build inside the override, so the literal string override_dh_auto_build is passed as a positional argument into the pybuild/setup.py command line. The standard form is dh_auto_build --buildsystem=pybuild with no $@. 5. Empty From: header in the combined patch debian/patches/dgit-changes:1 has From: with no value. It's the expected dgit single-debian-patch artifact, but the empty author line is sloppy and could confuse tooling. Hope this is helpful :-) Thanks! Full review details: https://dfsg-new-queue.debian.org/reviews/python-libsoundtouch
