The Debian NEW review of python-locationsharinglib 5.0.3-1 has been completed.
Decision: ACCEPTED
Reviewer: Andrew McMillan
Review comment:
Hi,
Some pedantica packaging issues you might want to review...
Packaging quality
1. pybuild-plugin-pyproject declared but no pyproject.toml exists.
debian/control:11 depends on pybuild-plugin-pyproject, yet the tarball has only
legacy setup.py/setup.cfg (no pyproject.toml anywhere). The plugin is
unused/inconsistent with the actual build system.
2. override_dh_auto_test is empty (debian/rules:10-11)
it contains only a comment and never calls dh_auto_test, so the test suite is
silently skipped. The rationale comment ("only an empty test scaffold") is only
roughly accurate: tests/test_locationsharinglib.py does define a
BetamaxTestCase class, just with no test methods. Combined with the <!nocheck>
test-only Build-Depends (betamax, pytest, cachetools, coloredlogs, pytz) that
are then never exercised, this means autopkgtest-pkg-python runs nothing
meaningful.
3. Docs build isn't gated on nodoc.
debian/rules:8 unconditionally runs sphinx-build, while the sphinx/rtd-theme
Build-Depends are marked <!nodoc> (debian/control:21-22). Building with
dpkg-buildpackage -Pnodoc would still attempt the docs build and fail.
4. _version.py fallback is incomplete (minor).
The Debian patch (debian/patches/dgit-changes) adds from importlib.metadata
import version and catches only FileNotFoundError before it. When no .VERSION
is present and the package isn't installed as a distribution,
version('locationsharinglib') raises PackageNotFoundError (uncaught). Fine in
the Debian-installed case, but fragile.
Thanks!
Full review details:
https://dfsg-new-queue.debian.org/reviews/python-locationsharinglib
