Thanks for the thorough and rapid review! I applied all the fixes you
suggested, and will upload the source package once the CI passes.
[email protected]:
This is an automated message from the Debian DFSG, Licensing & New
Packages Team.
The Debian NEW review of pylibftdi 0.24.1-1 has been completed.
Decision: ACCEPTED
Reviewer: Andrew McMillan
Review comment:
Hi,
Some issues found in the review that could be fixed...
1. [important] [packaging] Autopkgtest cannot run: python3-pytest is not
installed
- Files: `debian/tests/control:1-4`, `debian/tests/unittests:6-10`
- Evidence: `debian/tests/control` has `Depends: @builddeps@`;
`debian/tests/unittests` runs `python${i} -m pytest -v tests`; `pyproject.toml`
lists pytest only under `[dependency-groups] dev`.
- Problem: The only dependency of the declared `Testsuite: autopkgtest` (DSC
`Testsuite: autopkgtest`) is `@builddeps@`, which expands to the Build-Depends
of the source; none of them provides the pytest runner, and the Debian build
never installs upstream's dev dependency group. The test therefore fails with
`ModuleNotFoundError: No module named 'pytest'`, so the salsa-ci pipeline and
the autopkgtest suite advertised in the package are red. This is a genuine
functional defect, not a lintian nit.
- Fix: Declare the runner, e.g. `Depends: @, @builddeps@, python3-pytest` (or
add python3-pytest to Build-Depends).
2. [minor] [packaging] Autopkgtest does not test the installed package
- Files: `debian/tests/control:2`, `pyproject.toml:113-115`
- Evidence: `Depends: @builddeps@` only (no `@`), plus `[tool.pytest.ini_options] pythonpath =
["src", "."]`.
- Problem: Because the test Depends omit `@` (the binary package(s) built by this source),
python3-pylibftdi is not installed in the testbed; together with `pythonpath = ["src",
"."]`, pytest imports pylibftdi from the unpacked source tree, so the shipped bytes are
never exercised. The tests could pass while a broken installed package goes unnoticed.
- Fix: Use `Depends: @, @builddeps@, python3-pytest` so the tests run against
the installed binary (this also fixes the missing pytest issue).
3. [minor] [packaging] debian/watch is in the old version 3 format
- Files: `debian/watch`
- Evidence: `version=3`
- Problem: Version 5 is the current format of `debian/watch`.
- Fix: Convert it to version 5; a mechanical conversion is suggested below:
==========================================================
Version: 5
# Run the "uscan" command to check for upstream updates and more.
Template: Github
Dist: https://github.com/codedstructure/pylibftdi
==========================================================
Thanks!
Full review details: https://dfsg-new-queue.debian.org/reviews/pylibftdi
