Bug#1152290: hdf5-helpers, libhdf5-{openmpi,mpich}-dev: compiler wrappers need pkg-config but don't depend on it

[Scot Breitenfeld]

Package: hdf5-helpers
Version: 2.2.0+repack-5
Severity: important
Tags: patch

Dear Maintainer,

In HDF5 2.x the compiler wrappers are shell scripts that run pkg-config
to get the compile and link flags. These are h5cc, h5fc and h5c++ in
hdf5-helpers, and h5pcc.<flavor> and h5pfc.<flavor> in
libhdf5-openmpi-dev and libhdf5-mpich-dev. None of these packages
depends on pkg-config, and neither does libhdf5-dev, so on a system
where nothing else has installed it the wrappers fail:

 $ h5cc test.c
 /usr/bin/h5cc: 1: pkg-config: not found
 pkg-config failed with arguments: --define-variable=prefix=/usr --cflags 
--libs hdf5_serial hdf5_serial_hl

I saw this after installing libhdf5-dev 2.2.0 in a minimal Ubuntu 24.04
container (our rebuild of 2.2.0+repack-5 on the openSUSE Build
Service). The same happens on any system without pkgconf.

The attached patch adds "pkgconf | pkg-config" to Depends of
hdf5-helpers, libhdf5-openmpi-dev and libhdf5-mpich-dev, in both
debian/control and debian/control.in.

Thanks,
Scot Breitenfeld
The HDF Group

diff -ru a/debian/control b/debian/control
--- a/debian/control
+++ b/debian/control
@@ -271,7 +271,8 @@
          libcurl4-openssl-dev | libcurl-dev,
          libssl-dev,
          libopenmpi-dev,
-         ${misc:Depends}
+         ${misc:Depends},
+         pkgconf | pkg-config
 Suggests: libhdf5-doc
 Breaks: libhdf5-mpi-dev (= 1.10.6+repack-1~exp4)
 Description: HDF5 - development files - OpenMPI version
@@ -400,7 +401,8 @@
          libcurl4-openssl-dev | libcurl-dev,
          libssl-dev,
          libmpich-dev (>= 3.3-3~),
-         ${misc:Depends}
+         ${misc:Depends},
+         pkgconf | pkg-config
 Suggests: libhdf5-doc
 Breaks: libhdf5-mpi-dev (= 1.10.6+repack-1~exp4)
 Description: HDF5 - development files - MPICH2 version
@@ -448,7 +450,8 @@
 Package: hdf5-helpers
 Architecture: any
 Depends: ${shlibs:Depends},
-         ${misc:Depends}
+         ${misc:Depends},
+         pkgconf | pkg-config
 Description: HDF5 - Helper tools
  Hierarchical Data Format 5 (HDF5) is a file format and library for
  storing scientific data.  HDF5 was designed and implemented to address
diff -ru a/debian/control.in b/debian/control.in
--- a/debian/control.in
+++ b/debian/control.in
@@ -271,7 +271,8 @@
          libcurl4-openssl-dev | libcurl-dev,
          libssl-dev,
          libopenmpi-dev,
-         ${misc:Depends}
+         ${misc:Depends},
+         pkgconf | pkg-config
 Suggests: libhdf5-doc
 Breaks: libhdf5-mpi-dev (= 1.10.6+repack-1~exp4)
 Description: HDF5 - development files - OpenMPI version
@@ -400,7 +401,8 @@
          libcurl4-openssl-dev | libcurl-dev,
          libssl-dev,
          libmpich-dev (>= 3.3-3~),
-         ${misc:Depends}
+         ${misc:Depends},
+         pkgconf | pkg-config
 Suggests: libhdf5-doc
 Breaks: libhdf5-mpi-dev (= 1.10.6+repack-1~exp4)
 Description: HDF5 - development files - MPICH2 version
@@ -448,7 +450,8 @@
 Package: hdf5-helpers
 Architecture: any
 Depends: ${shlibs:Depends},
-         ${misc:Depends}
+         ${misc:Depends},
+         pkgconf | pkg-config
 Description: HDF5 - Helper tools
  Hierarchical Data Format 5 (HDF5) is a file format and library for
  storing scientific data.  HDF5 was designed and implemented to address

smime.p7s
Description: S/MIME cryptographic signature