On 2026-10-29, Chris Lamb wrote:
> Vagrant Cascadian wrote:
>
>> FWIW, diffoscope 335 does build fine on recent guix, including that
>> specific test passing.
>
> Could you quickly run/apply this diff? :)  Would be useful to know what
> "should" be there…
>
> --- tests/comparators/test_zip.py
> +++ tests/comparators/test_zip.py
> @@ -160,6 +160,13 @@ def test_nupkg_metadata(nupkg_differences, nupkg1, 
> nupkg2):
>  
>  @skip_unless_tools_exist("zipinfo")
>  def test_nupkg_compressed_files(nupkg_differences):
> +    for idx, x in enumerate(nupkg_differences):
> +        with open(f"nupkg_differences_{idx}.diff", "w") as f:
> +            print(f"source1={x.source1!r}", file=f)
> +            print(f"source2={x.source2!r}", file=f)
> +            print(f"comments={x.comments!r}", file=f)
> +            print(f"\n{x.unified_diff}", file=f)
> +
>      assert (
>          nupkg_differences[-1].source1
>
> It should spit out a bunch of small (eg.) nupkg_differences_2.diff files.

I did give this a try yesterday, although nothing showed in the build
log... my guess is some part of the build process ate stdout...

live well,
  vagrant

Attachment: signature.asc
Description: PGP signature

Reply via email to