On Mon, Jul 17, 2006 at 07:22:11PM +0100, Dave Ewart wrote: > On Monday, 17.07.2006 at 15:30 +0200, Adam Borowski wrote: > > Hello. If the output is not a terminal (like, when using diff to make a > > patch), colordiff will still happily colorize the output. This is bad if > > "diff" is an alias to "colordiff", as suggested in the manpage.
> > The fix is simple: > > > > exec "/usr/bin/diff",@ARGV unless -t STDOUT; > > It's unclear to me exactly what you're suggesting: are you suggesting an > alternative means of aliasing 'diff', or is the above a modification to > the code? Sorry, my bad. I meant the latter. > I'd find it helpful if you could turn the above into a patch, thanks. --- colordiff~ 2006-07-17 15:01:56.564810563 +0200 +++ colordiff 2006-07-17 15:01:56.564810563 +0200 @@ -31,6 +31,8 @@ use Getopt::Long qw(:config pass_through); use IPC::Open2; +exec "/usr/bin/diff",@ARGV unless -t STDOUT; + my $app_name = 'colordiff'; my $version = '1.0.4'; my $author = 'Dave Ewart'; (Of course, the exact place doesn't really matter.) > > I already reported this bug upstream over three years ago, but it > > appears to be left unfixed. At least, the bug bit me today again :p > > [Odd - I've got no record of you ever contacting me, which is strange > since I'm usually fairly obsessive about keeping that sort of email. > Did I ever reply?! Apologies if not, but I don't think I got your > message.] I'm afraid I didn't use mail, just the SourceForge bug report system: https://sourceforge.net/tracker/?func=detail&aid=745456&group_id=65829&atid=512406 I'm not sure if they mail you any new bug reports by default; I would probably fail to notice such reports on my projects for years, too. Cheers and schtuff, -- 1KB // Microsoft corollary to Hanlon's razor: // Never attribute to stupidity what can be // adequately explained by malice. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
