Hello Miguel, On Fri, July 28, 2006 10:30, Miguel Gea Milvaques wrote: > I think this is not a good idea.
Thanks for your comments, but I'm afraid I disagree. > It's true that it switch from code to literal, but it'll give problems with > old packages that don't close this tag. I have been working with PHP since the late 1990's and I've never seen a problem with not closing an open <?php at EOF. Can you give a concrete example where this will fail? > On other hand the problem reported by thisjs it's a problem that has > to be resolved by the packager. It's usual in a php file mix code and > literal parts and it's important!. I can't imagine where one would want to use literal mode inside the database configuration file as generated by dbconfig-common. This change does not have any negative effect on any application including the file. I don't understand the problem and again welcome a concrete example illustrating where this would go wrong. To close, your mail doesn't contain information about how you think the mentioned problem with stray whitespace after the '?>' can be circumvented. I've seen quite some real-life situations where this happened and this caused for example spaces to be inserted into binary files sent to the user, thus corrupting them. It's all too easy, especially with a config file. Thijs
