Package: dhcp3
Severity: minor
Tags: patch

Hi,

There are various problems with your debconf templates. Full patches are
attached. Here are my comments:

======================
dhcp3-client.templates
> Type: note
> _Description: dhclient-script has moved!
>  As of 3.0.4-2, dhclient-script is installed in /sbin and is no longer a
>- conffile. /etc/dhcp3/dhclient-script appears to have been modfied at some
>+ conffile. /etc/dhcp3/dhclient-script appears to have been modified at some

typo

>  Naturally, you should exercise caution if you are managing a remote server 
> via
>  an interface using DHCP.
>- .
>- maybe this makes it so

Remove this meaningless piece of sentence.


======================
dhcp3-relay.templates
> Template: dhcp3-relay/servers
> Type: string
>-_Description: What DHCP servers should the DHCP relay forward requests to?
>+_Description: DHCP servers to which the DHCP relay should forward requests to:

malformed prompt for a "string" template.

> Template: dhcp3-relay/interfaces
> Type: string
>-_Description: On what network interfaces should the DHCP server listen?
>+_Description: Network interfaces on which the DHCP server should listen:

malformed prompt for a "string" template.

>  The names of the network interfaces that dhcrelay should attempt to
>- configure may be specified on the command line using  the -i option. If no
>- interface names are specified on the command line dhcrelay  will identify
>+ configure may be specified on the command line using the -i option. If no
>+ interface names are specified on the command line dhcrelay will identify

Remove two extra spaces in the middle of a sentence.

> Template: dhcp3-relay/options
> Type: string
>-_Description: Additional options for the Daemon?
>+_Description: Additional options for the daemon:

malformed prompt for a "string" template.

>- Additional options for the DHCP relay daemon.
>+ Additional options for the DHCP relay daemon can be specified.

Non-verbal sentences should be avoided in the long description.


======================
dhcp3-server.templates
> Template: dhcp3-server/config_warn
> Type: note
>-_Description: The DHCP server requires manual configuration after 
>installation!!!
>+_Description: Manual configuration required after installation!

Please don't be so enthusiastic :-) I'm also rephrasing this sentence so
that it looks more like a title.

>- After the DHCP server is installed you will need to  manually configure it
>+ After the DHCP server is installed you will need to manually configure it

Remove extra space in the middle of a sentence.

> Template: dhcp3-server/interfaces
> Type: string
>-_Description: On what network interfaces should the DHCP server listen?
>+_Description: Network interfaces on which the DHCP server should listen:

malformed prompt for a "string" template.

> Template: dhcp3-server/new_auth_behavior
> Type: note
>-_Description: The version 3 DHCP server is now non-authoritative by default
>+_Description: Non-authoritative version of DHCP server
>+ The version 3 DHCP server is now non-authoritative by default.
>+ .

Rephrased so that it looks more like a title for the short description.


Cheers,

-- 
Thomas Huriaux
--- dhcp3-client.templates.orig 2006-08-22 14:02:22.000000000 +0200
+++ dhcp3-client.templates      2006-08-22 14:05:18.000000000 +0200
@@ -2,7 +2,7 @@
 Type: note
 _Description: dhclient-script has moved!
  As of 3.0.4-2, dhclient-script is installed in /sbin and is no longer a
- conffile. /etc/dhcp3/dhclient-script appears to have been modfied at some
+ conffile. /etc/dhcp3/dhclient-script appears to have been modified at some
  point, so it has not been removed, however it is no longer being used.
  .
  Please consider using the hook infrastructure instead of modifying
@@ -26,5 +26,3 @@
  .
  Naturally, you should exercise caution if you are managing a remote server via
  an interface using DHCP.
- .
- maybe this makes it so
--- dhcp3-relay.templates.orig  2006-08-22 14:03:07.000000000 +0200
+++ dhcp3-relay.templates       2006-08-22 14:08:55.000000000 +0200
@@ -1,6 +1,6 @@
 Template: dhcp3-relay/servers
 Type: string
-_Description: What DHCP servers should the DHCP relay forward requests to?
+_Description: DHCP servers to which the DHCP relay should forward requests to:
  The name or IP address of at least one DHCP server to which DHCP and BOOTP
  requests should be relayed must be specified on the command line.
  .
@@ -9,16 +9,16 @@
 
 Template: dhcp3-relay/interfaces
 Type: string
-_Description: On what network interfaces should the DHCP server listen?
+_Description: Network interfaces on which the DHCP server should listen:
  The names of the network interfaces that dhcrelay should attempt to
- configure may be specified on the command line using  the -i option. If no
- interface names are specified on the command line dhcrelay  will identify
+ configure may be specified on the command line using the -i option. If no
+ interface names are specified on the command line dhcrelay will identify
  all network interfaces, elimininating non-broadcast interfaces if
  possible, and attempt to configure each interface.
 
 Template: dhcp3-relay/options
 Type: string
-_Description: Additional options for the Daemon?
- Additional options for the DHCP relay daemon.
+_Description: Additional options for the daemon:
+ Additional options for the DHCP relay daemon can be specified.
  .
  Example: "-m replace" or "-a -D"
--- dhcp3-server.templates.orig 2006-08-22 14:03:12.000000000 +0200
+++ dhcp3-server.templates      2006-08-22 14:12:53.000000000 +0200
@@ -1,7 +1,7 @@
 Template: dhcp3-server/config_warn
 Type: note
-_Description: The DHCP server requires manual configuration after 
installation!!!
- After the DHCP server is installed you will need to  manually configure it
+_Description: Manual configuration required after installation!
+ After the DHCP server is installed you will need to manually configure it
  by editing the file /etc/dhcp3/dhcpd.conf. Please note that a sample
  dhcpd.conf is supplied, but the configuration there is just a sample that
  requires editing and customization to your own network environment.
@@ -10,7 +10,7 @@
 
 Template: dhcp3-server/interfaces
 Type: string
-_Description: On what network interfaces should the DHCP server listen?
+_Description: Network interfaces on which the DHCP server should listen:
  You can enter one or more valid interface names, like eth0. If you want to
  serve DHCP request on more than one interface, please separate them with
  spaces. If you want dhcpd to figure out the interface leave this parameter
@@ -18,7 +18,9 @@
 
 Template: dhcp3-server/new_auth_behavior
 Type: note
-_Description: The version 3 DHCP server is now non-authoritative by default
+_Description: Non-authoritative version of DHCP server
+ The version 3 DHCP server is now non-authoritative by default.
+ .
  This means that if a client requests an address that the server knows
  nothing about and the address is incorrect for that network segment, the
  server will _not_ send a DHCPNAK (which tells the client it should stop

Attachment: signature.asc
Description: Digital signature

Reply via email to