Dear Petter,

The patch change a lot of indentation, making it hard to track what
are real changes and what are just tabs converted to spaces.  It would
be better with a patch without these irrelevant whitespace changes.

That is true.
The factorization of kill and start scripts in two dedicated functions (to not duplicate the code: one call to count the number of scripts, one call to execute them) will probably make diff show a lot of lines anyway - I understand your point and can do nothing else but agree. I'll have another look but if I do not post again a patch that's because I could not make it smaller.


Tested with splashutils, not tested with bootsplash.

Is it tested with usplash too?

No, with splashutils only. The $debug in front of the usplash_write will show very well what happens, and I believe this must work with usplash as well. Can somebody in your team do this thest?
Anyway you have a point; this must be tested.
I'll see what I can do in here (I have to install usplash; why not! I'll be happy to test it).

Cheers, JD.



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to