hi
Ludek Smid <[EMAIL PROTECTED]> made a patch for this bug , that is
in attachment
here is also his reply to my mail, with further explanation
a.
----- Forwarded message from Ludek Smid <[EMAIL PROTECTED]> -----
From: Ludek Smid <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Subject: Re: patch for bug 190406 in xdelta
Hi,
A Mennucc wrote:
>I am interested in fixing the xdelta bug
> "Deltas generated on 32bit fail to apply on 64bit machines"
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=147187
>that is also
> https://sourceforge.net/tracker/?func=detail&atid=106966&aid=1509857&group_id=6966
>
>[EMAIL PROTECTED] told me that the same bug was listed in
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190406
>where it says that you fixed it; so I looked around and downloaded
>ftp://download.fedora.redhat.com/pub/fedora/linux/core/development/source/SRPMS/xdelta-1.1.3-20.src.rpm
>
>indeed the changelog says that you fixed the bug
>
>which patch corrects the problem?
>xdelta-1.1.3-allocbug.patch ?
Yes, that's the correct patch.
>what about deltas? if I create a delta with 1.1.3-20, will it be possible
>to apply it with older version?
There was no change in delta format, the patch just fixes memory
allocation bug that prevented to apply patches created on x86 platform
to be applied on x86_64 platform. For some reason, amount of memory to
allocate is specified in the delta file, but on 64bit platforms, you
need more space for pointers.
If you have more questions, let me know.
Regards,
Ludek
----- End forwarded message -----
--
Andrea Mennucc
--- xdelta-1.1.3/libedsio/fh.c.allocbug 2001-06-12 05:16:41.000000000 +0200
+++ xdelta-1.1.3/libedsio/fh.c 2006-05-09 12:23:04.000000000 +0200
@@ -92,6 +92,8 @@
{
if (! ssource->fh->table->table_handle_getui (ssource->fh,
&source->alloc_total))
return ST_Error;
+ /* There are 12 pointers in all required structures. So 64 bit arch
needs 48 more bytes. */
+ source->alloc_total += (sizeof(void *) - 4) * 12;
}
return x;
