tags 391181 + patch
thanks
Hi,
I've just uploaded a fix for that bug to the delayed queue (7 days).
Here is attached the patch I applied for closing the bug and enhancing a
bit the package shape.
Basically, it's about fixing lintian errors (#DEBHELPER# tags were
missing in maintainer scripts) and making sure the cron.d script behaves
correctly.
I also added a postrm script that takes care manually of the purge
phase.
Regards,
--
Alexis Sukrieh
[EMAIL PROTECTED]
0x1EE5DD34 [EMAIL PROTECTED]
The real glory of maintainership isn't making the big and important
decisions. The real glory lies in all the small stuff that doesn't
really matter, and that people will just argue forever.
-- Linus Torvalds
diff -uNbBr pdbv-2.0.10.1/configure pdbv-2.0.10.1.1/configure
--- pdbv-2.0.10.1/configure 2005-02-23 11:43:07.000000000 +0100
+++ pdbv-2.0.10.1.1/configure 2006-10-08 11:34:37.000000000 +0200
@@ -203,17 +203,17 @@
# see http://savannah.nongnu.org/bugs/?func=detailbug&bug_id=2691&group_id=2348
echo -n "creating $CRONFILE... "
echo "# May run on a daily basis (prefered for pdbv 1.x.x)." > $CRONFILE
-echo "20 15 * * * nobody $PREFIX/bin/pdbv --cron=daily" >> $CRONFILE
+echo "20 15 * * * nobody [ -x $PREFIX/bin/pdbv ] && $PREFIX/bin/pdbv
--cron=daily" >> $CRONFILE
echo " " >> $CRONFILE
echo "# May run on a hourly basis (prefered for pdbv 2.x.x)." >> $CRONFILE
-echo "32 * * * * nobody $PREFIX/bin/pdbv --cron=hourly" >> $CRONFILE
+echo "32 * * * * nobody [ -x $PREFIX/bin/pdbv ] && $PREFIX/bin/pdbv
--cron=hourly" >> $CRONFILE
echo " " >> $CRONFILE
echo "# Once per week, regenerate the whole output without tests." >> $CRONFILE
echo "# Can be useful in regard of pop-con results, or because" >> $CRONFILE
echo "# it happens that a package is replaced by a package of the" >> $CRONFILE
echo "# exact same version." >> $CRONFILE
-echo "05 18 * * 1 nobody $PREFIX/bin/pdbv --cron=daily --force" >> $CRONFILE
-echo "05 18 * * 1 nobody $PREFIX/bin/pdbv --cron=hourly --force" >>
$CRONFILE
+echo "05 18 * * 1 nobody [ -x $PREFIX/bin/pdbv ] && $PREFIX/bin/pdbv
--cron=daily --force" >> $CRONFILE
+echo "05 18 * * 1 nobody [ -x $PREFIX/bin/pdbv ] && $PREFIX/bin/pdbv
--cron=hourly --force" >> $CRONFILE
echo " " >> $CRONFILE
echo "done"
diff -uNbBr pdbv-2.0.10.1/debian/changelog pdbv-2.0.10.1.1/debian/changelog
--- pdbv-2.0.10.1/debian/changelog 2005-03-06 15:34:01.000000000 +0100
+++ pdbv-2.0.10.1.1/debian/changelog 2006-10-08 12:05:08.000000000 +0200
@@ -1,3 +1,16 @@
+pdbv (2.0.10.1.1) unstable; urgency=low
+
+ * Non-maintainer upload.
+ * Added the #DEBHELPER# tag in maintainer scripts (fixes lintian warnings).
+ * Moved the Build-Depends-Indep for debhelper to Build-Depends to fix a
+ lintian error.
+ * Make sure the cron.d/pdbv script is removed when the packaged is purged.
+ * Patched cron.d/pdbv in order to check that /usr/bin/pdbv is present at
+ runtime.
+ (closes: #391181)
+
+ -- Alexis Sukrieh <[EMAIL PROTECTED]> Sun, 8 Oct 2006 12:04:31 +0200
+
pdbv (2.0.10.1) unstable; urgency=low
* New upstream release.
diff -uNbBr pdbv-2.0.10.1/debian/control pdbv-2.0.10.1.1/debian/control
--- pdbv-2.0.10.1/debian/control 2005-03-06 15:28:40.000000000 +0100
+++ pdbv-2.0.10.1.1/debian/control 2006-10-08 11:47:20.000000000 +0200
@@ -3,7 +3,8 @@
Priority: optional
Maintainer: Mathieu Roy <[EMAIL PROTECTED]>
Uploaders: Jerome Marant <[EMAIL PROTECTED]>
-Build-Depends-Indep: gettext, debhelper (>= 4.1.16)
+Build-Depends-Indep: gettext
+Build-Depends: debhelper (>= 4.1.16)
Standards-Version: 3.6.1.0
Package: pdbv
diff -uNbBr pdbv-2.0.10.1/debian/postinst pdbv-2.0.10.1.1/debian/postinst
--- pdbv-2.0.10.1/debian/postinst 2004-06-05 15:38:57.000000000 +0200
+++ pdbv-2.0.10.1.1/debian/postinst 2006-10-08 12:04:19.000000000 +0200
@@ -43,4 +43,8 @@
`chown nobody $output_dir`;
+# dh_installdeb will replace this with shell code automatically
+# generated by other debhelper scripts.
+#DEBHELPER#
+
exit;
diff -uNbBr pdbv-2.0.10.1/debian/postrm pdbv-2.0.10.1.1/debian/postrm
--- pdbv-2.0.10.1/debian/postrm 1970-01-01 01:00:00.000000000 +0100
+++ pdbv-2.0.10.1.1/debian/postrm 2006-10-08 11:45:44.000000000 +0200
@@ -0,0 +1,35 @@
+#! /bin/sh
+# postrm script for pdbv
+set -e
+
+# summary of how this script can be called:
+# * <postrm> `remove'
+# * <postrm> `purge'
+# * <old-postrm> `upgrade' <new-version>
+# * <new-postrm> `failed-upgrade' <old-version>
+# * <new-postrm> `abort-install'
+# * <new-postrm> `abort-install' <old-version>
+# * <new-postrm> `abort-upgrade' <old-version>
+# * <disappearer's-postrm> `disappear' <r>overwrit>r> <new-version>
+# for details, see /usr/share/doc/packaging-manual/
+case "$1" in
+
+ purge)
+ # Remove possible conffiles
+ if [ -e /etc/cron.d/pdbv ]; then
+ rm -f /etc/cron.d/pdbv
+ fi
+ ;;
+
+ remove|upgrade|failed-upgrade|abort-install|abort-upgrade|disappear)
+ ;;
+
+ *)
+ echo "postrm called with unknown argument \`$1'" >&2
+ exit 0
+ ;;
+esac
+
+# dh_installdeb will replace this with shell code automatically
+# generated by other debhelper scripts.
+#DEBHELPER#
diff -uNbBr pdbv-2.0.10.1/debian/prerm pdbv-2.0.10.1.1/debian/prerm
--- pdbv-2.0.10.1/debian/prerm 2004-06-05 15:38:57.000000000 +0200
+++ pdbv-2.0.10.1.1/debian/prerm 2006-10-08 12:04:28.000000000 +0200
@@ -25,5 +25,8 @@
}
}
+# dh_installdeb will replace this with shell code automatically
+# generated by other debhelper scripts.
+#DEBHELPER#
exit;
