Package: freeradius
Severity: important
Tags: patch

When pthreads are enabled (default on Debian) and crypt 
encryption is used, FreeRADIUS crashes.

The following patch fixes the bug :

diff -Nurp freeradius-1.0.1/src/lib/crypt.c freeradius-1.0.1.new/src/lib/crypt.c
--- freeradius-1.0.1/src/lib/crypt.c    2004-02-26 20:04:20.000000000 +0100
+++ freeradius-1.0.1.new/src/lib/crypt.c        2005-03-18 13:25:55.187248153 
+0100
@@ -49,7 +49,7 @@ int lrad_crypt_check(const char *key, co
        /*
         *      Ensure we're thread-safe, as crypt() isn't.
         */
-       if (!lrad_crypt_init == 0) {
+       if (lrad_crypt_init == 0) {
                pthread_mutex_init(&lrad_crypt_mutex, NULL);
                lrad_crypt_init = 1;
        }

It's obviously a mistake, which causes pthread_mutex_lock/unlock
to be called on an uninitialized mutex.

I've not been able to reproduce the crash recently, but I 
experienced it only two days ago (tested on several OSes
and platforms, all the same).

-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: sparc (sparc64)
Kernel: Linux 2.6.10
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to