On Mon, 13 Nov 2006 15:46:44 +0100 Frank Küster <[EMAIL PROTECTED]> wrote:
> I was just bug-hunting. I don't know what the reason was why the device
> was unavailable, but I think there may be valid setups where this is the
> case.
I just read in another report by Vagrant that he was trying to use a special
purpose swap partition for suspending only. And indeed it wasn't active during
the upgrade.
> What about something like
>
> if ! echo $SWAPLIST | grep -q $SWAPDEFAULT; then
> # add the SWAPDEFAULT device to SWAPLIST
> SWAPDEFAULT="${SWAPDEFAULT} # currently not available"
> SWAPLIST=${SWAPLIST}${KOMMA}${SWAPDEFAULT}
> fi
>
> right after populating SWAPLIST? Hm, the comment might need special
> treatment later on, since it's probably not yet in the configuration
> file. And of course it assumes that the configuration file may contain
> in-line comments.
The config format doesn't allow for in-line comments, but that could be fixed
of course...
I am inclined however to just add the value from the configuration file to the
list. If people want to change the configuration file by hand, they should be
allowed to shoot themselves it the foot. The worst that can happen is that
the partition doesn't exist, but then they will get a big fat warning next time
they try to suspend any way.
grts Tim
signature.asc
Description: PGP signature
