On Thu, 30 Nov 2006, Anton Altaparmakov wrote:
> I read the code and it does it. I do not believe in sniffing as you put
> it. That is useless as you never know what/why the software is doing
> something. The code itself shows exactly what happens. I prefer to stick
> with that.
I prefer understanding the code, testing the understanding is correct, and
getting continuous user confirmations that both of the previous are indeed
right.
> > Anyway, ntfsresize always unconditionally emptied the journal. So what did
> > you do which made Vista booting? It's either incorrect journal checking on
> > Vista or a side-effect of your changes.
>
> I did two things to libntfs:
> - make the journal be emptied at mount time and
> - set the dirty bit at mount time.
> Then at umount time:
> - clear the dirty bit again unless the volume was dirty when it
> was mounted.
>
> I then did these things to ntfsresize:
> - remove the journal emptying from ntfsresize as it is done by
> libntfs now at mount time,
> - remove the setting dirty of volume as that is also done at mount
> time;
In other words, they were moved to libntfs. No real change here.
> - make ntfsresize unmount the volume if one aborts which will
> clear the dirty bit again if the volume was not dirty to start with; and
> finally,
> - disable the unmount in ntfsresize once it is going to start
> resizing ntfs as you said that unmounting at that point becomes dangerous.
This also has no effect during a successful resize process.
> This fixes ntfsresize on Vista for me.
You didn't answer how the journal looks after running ntfsresize without
your changes. That is, the non-empty journal file detection indeed works on
Vista.
I'd like to emphasize that your change is very dangerous. You did something
which is not understood at all. Perhaps Vista can boot now in your case, but
it's also possible that it will cause serious problems in other scenarios.
Szaka
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
