On Wed, Dec 13, 2006 at 08:56:52PM +0100, A Mennucc wrote: > Pierre Habouzit ha scritto: > > On Wed, Dec 13, 2006 at 05:53:03PM +0100, A Mennucc wrote: > >> we should understand why ref==0 > >> > >> anyway I will add an assert > > > > O_o *blink* *blink* > > > > do you know that assert is a macro that may be disabled if for some > > reason the build system defines NDEBUG ?! > > you are criticizing my way of solving this bug *even before I sit down > and start writing the code* > > even supposing that > - I would use assert(ref) > - the code is compiled with NDEBUG > did you consider the fact that I will check my patch against your > foobar.mpeg, in the end, to make sure that it will work? > > congratulations! you really know how to go along and collaborate with > other people > (yes that is sarcasm)
I did not proposed to use assert to fix bugs in the first place. FYI, the patch to compile against debian's libmpeg2.a (yes using your beloved static compiling) is ridiculously small (see attachment). I won't quote the mail full of hate where you state that you will never use that, I'm not *that* mean. Though, it seems the problem is not only there, but also in the sole 270-line long file libmpcodecs/vd_libmpeg2.c that is the sole one to use the mpeg2 library. it has the very very very bad idea to use mpeg2 internals and to deal with mpeg2dec_t initialization by itself. As a result, even using debian's libmpeg2 make it fail, so I suppose that the culprit is in vd_libmpeg2.c. I must reckon I've not enough knowledge to procede with further tests and debugging. But knowing that the problem *only* lies in that 211-slocs long file, I've good hope that someone more skilled with video thingies can fix that for real. Cheers, -- ·O· Pierre Habouzit ··O [EMAIL PROTECTED] OOO http://www.madism.org
diff -u mplayer-1.0~rc1/debian/control.in mplayer-1.0~rc1/debian/control.in --- mplayer-1.0~rc1/debian/control.in +++ mplayer-1.0~rc1/debian/control.in @@ -11,7 +11,7 @@ (>= 0.0.0.alpha3-1), libesd0-dev, libasound2-dev (>= 1.0.6-3), libvorbis-dev, liblircclient-dev, libfreetype6-dev, libdvdread3-dev, libcdparanoia0-dev, libfontconfig1-dev, libjpeg62-dev, libungif4-dev, - libgtk2.0-dev, libdirectfb-dev, libcaca-dev, @XLIBS@, @EXTRA_BUILDDEP@ + libgtk2.0-dev, libdirectfb-dev, libcaca-dev, libmpeg2-4-dev, @XLIBS@, @EXTRA_BUILDDEP@ Package: @MPLAYER@ Architecture: any diff -u mplayer-1.0~rc1/debian/control mplayer-1.0~rc1/debian/control --- mplayer-1.0~rc1/debian/control +++ mplayer-1.0~rc1/debian/control @@ -11,7 +11,7 @@ (>= 0.0.0.alpha3-1), libesd0-dev, libasound2-dev (>= 1.0.6-3), libvorbis-dev, liblircclient-dev, libfreetype6-dev, libdvdread3-dev, libcdparanoia0-dev, libfontconfig1-dev, libjpeg62-dev, libungif4-dev, - libgtk2.0-dev, libdirectfb-dev, libcaca-dev, libx11-dev, libxext-dev, libxinerama-dev, libxv-dev, libxvmc-dev, libxxf86dga-dev, libxxf86vm-dev, x-dev, + libgtk2.0-dev, libdirectfb-dev, libcaca-dev, libmpeg2-4-dev, libx11-dev, libxext-dev, libxinerama-dev, libxv-dev, libxvmc-dev, libxxf86dga-dev, libxxf86vm-dev, x-dev, Package: mplayer Architecture: any only in patch2: unchanged: --- mplayer-1.0~rc1.orig/Makefile +++ mplayer-1.0~rc1/Makefile @@ -177,7 +177,7 @@ PARTS += liba52 endif ifeq ($(LIBMPEG2),yes) -PARTS += libmpeg2 +#PARTS += libmpeg2 endif ifeq ($(FAAD_INTERNAL),yes) COMMON_LIBS += libfaad2/libfaad2.a @@ -231,8 +231,8 @@ COMMON_LIBS += liba52/liba52.a endif ifeq ($(LIBMPEG2),yes) -COMMON_DEPS += libmpeg2/libmpeg2.a -COMMON_LIBS += libmpeg2/libmpeg2.a +#COMMON_DEPS += libmpeg2/libmpeg2.a +COMMON_LIBS += /usr/lib/libmpeg2.a endif ifeq ($(FAAD_INTERNAL),yes) COMMON_DEPS += libfaad2/libfaad2.a
pgpqNyKsp1j3S.pgp
Description: PGP signature
