-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Ethan Benson <[EMAIL PROTECTED]> writes:
> On Tue, Mar 22, 2005 at 09:15:55PM +0000, Roger Leigh wrote: >> Package: yaboot >> Version: 1.3.13-3 >> Severity: normal >> Tags: patch >> >> ybin and mkofboot hardcode /dev/nvram as the nvram device. devfs (and > > mkofboot is a symlink to ybin. your patches are redundant. Sorry about that--I identified the files on the system using grep. >> udev, using devfs.rules) use /dev/misc/nvram instead. > > devfs is obsolete and slated for removal from 2.6 soon. That's true. However, the naming scheme is not devfs-specific, and is used by others. >> The attached patch checks for both devices so that it will work on >> both systems. > > since devfs is going away is this really necessary? Yes. The device naming scheme is independent of devfs. > users of udev probably use the sensible traditional naming, and can > more easily fix the udev rules to put the nvram device is the > correct location. The "correct" location is rather subjective. I use the alternate scheme because I prefer it, and I'm not the only one to do so. The udev devfs.rules scheme is in common use and supported by the udev maintainer (who also uses it himself), and on such systems ybin and mkofboot are broken. I also used the scheme without devfs or udev for several years (but I've only recently moved to powerpc). devfs-style device names are currently supported fairly comprehensively throughout the whole Debian system. >> Please note that this patch depends upon #300946 to be fixed in >> nvsetenv (powerpc-utils) before this patch will have any effect. > > unless nvsetenv gets changed this patch should not be applied > as it will prevent ybin from doing proper error checking. (ybin > should not accept non-standard /dev/nvram locations if nvsetenv will > not). Sure. I may yet alter the nvsetenv patch to allow the nvram device to be configurable at runtime, which would make this patch rather more robust. I'll discuss that with the powerpc-utils maintainer first, though. Regards, Roger - -- Roger Leigh Printing on GNU/Linux? http://gimp-print.sourceforge.net/ Debian GNU/Linux http://www.debian.org/ GPG Public Key: 0x25BFB848. Please sign and encrypt your mail. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (GNU/Linux) Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/> iD8DBQFCQa4FVcFcaSW/uEgRAo0cAKDMCDg8YlaeR06ZyVIgi4nd1jqPqwCfYNrB hAvW/hcQMFk+nqy/Ny3McLM= =uJW8 -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]