severity 411911 serious
thanks
On Wed, Feb 21, 2007 at 02:58:57PM -0500, Pat Suwalski wrote:
> Attached is a patch that works around the issue. Apparently, invoke-rc.d
> leaves junk in the standard file descriptors (no newline?). Debconf is
> then affected when it uses shell's "read". By redirecting the output to
> null, everything appears to work as before.
> To give some feedback to the user, perhaps some other message could be
> printed by DebianNet.pm instead.
No, the error is in printing anything to stdout *at all*, because
update-inetd is a tool that's called from maintainer scripts that may use
debconf, in which case stdout is an interface to the debconf frontend and
not to the user.
Note that for such a maintainer script to try to suppress the output from
update-inetd would also be bad, because update-inetd itself uses debconf, so
will expect to interact with the debconf frontend on stdout -- redirecting
update-inetd's stdout to /dev/null would break this interaction, so is no
solution to the problem at hand.
So yes, I believe fixing update-inetd to suppress the output from
invoke-rc.d is the correct answer here. Note that this problem has already
been worked around by postfix, an update of which is currently pending for
etch, and no other packages have so far been reported to suffer from this
behavior -- though off the top of my head, one package that might would be
samba. Either way, I'd been planning to address this since I saw that it
had been introduced in the previous NMU. Marco, if it's ok with you, I'd
like to re-NMU update-inetd with the attached patch.
Thanks,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
[EMAIL PROTECTED] http://www.debian.org/
diff -Nru /tmp/oXR9gZZb5X/update-inetd-4.27/debian/changelog /tmp/p15RftlHpH/update-inetd-4.27/debian/changelog
--- /tmp/oXR9gZZb5X/update-inetd-4.27/debian/changelog 2007-02-09 20:08:48.000000000 -0800
+++ /tmp/p15RftlHpH/update-inetd-4.27/debian/changelog 2007-02-21 15:16:12.000000000 -0800
@@ -1,3 +1,12 @@
+update-inetd (4.27-0.4) unstable; urgency=high
+
+ * Non-maintainer upload.
+ * High-urgency upload for RC bugfix.
+ * Suppress unexpected output from invoke-rc.d, which may break postinst
+ scripts calling update-inetd while using debconf. Closes: #411911.
+
+ -- Steve Langasek <[EMAIL PROTECTED]> Wed, 21 Feb 2007 12:36:50 -0800
+
update-inetd (4.27-0.3) unstable; urgency=low
* Non-maintainer upload
diff -Nru /tmp/oXR9gZZb5X/update-inetd-4.27/DebianNet.pm /tmp/p15RftlHpH/update-inetd-4.27/DebianNet.pm
--- /tmp/oXR9gZZb5X/update-inetd-4.27/DebianNet.pm 2007-02-09 20:11:39.000000000 -0800
+++ /tmp/p15RftlHpH/update-inetd-4.27/DebianNet.pm 2007-02-21 15:16:30.000000000 -0800
@@ -235,7 +235,7 @@
$_ = glob "/etc/init.d/*inetd";
if (m/\/etc\/init\.d\/(.*inetd)/) {
my $service = $1;
- system("invoke-rc.d $service restart");
+ system("invoke-rc.d $service restart >/dev/null");
}
}
return(1);
