tags 413397 + patch
thanks

The attached patch adds a update-inetd dependency for ifcico,
moves postinst to only run on configure, moves update-inetd part of
postrm to prerm so we know updated-inetd is still available.



I'm still not certain that the removal commands are correct.
        update-inetd --remove "^tfido"
        update-inetd --comment-chars "#disabled#" --enable tfido
        update-inetd --remove "^fido"
        update-inetd --comment-chars "#disabled#" --enable fido

What if ifcico is installed, some other package is installed,
other package disables ifcico and provides it's own "tfido" and
"fido" in inetd, and then ifcico is removed.
If I understand correctly, ifcico will then remove the active fido/tfido
handlers and reenable itself... ie. we have a problem with
install/remove order.
The removals should probably instead of matching for active fido/tfido
(which can be something else than ifcico) match on "fido.*ifcico".
OTOH I don't know if there is any other package that does this... I just
assumed there was since ifcico tries to disable handler before adding
it's own in inetd...

Please verify if this needs to be fixed....


-- 
Regards,
Andreas Henriksson
diff -uriNp ifmail-2.14tx8.10/debian/control 
ifmail-2.14tx8.10-updateinted/debian/control
--- ifmail-2.14tx8.10/debian/control    2007-03-05 13:50:48.000000000 +0100
+++ ifmail-2.14tx8.10-updateinted/debian/control        2007-03-05 
14:21:27.000000000 +0100
@@ -23,7 +23,7 @@ Description: Internet to Fidonet gateway
 
 Package: ifcico
 Architecture: any
-Depends: ${shlibs:Depends}, ifmail
+Depends: ${shlibs:Depends}, ifmail, update-inetd
 Conflicts: suidmanager (<< 0.50)
 Description: Fidonet Technology transport package
  Ifcico is a FidoTech mailer for connecting to other nodes via the phone
diff -uriNp ifmail-2.14tx8.10/debian/ifcico.postinst 
ifmail-2.14tx8.10-updateinted/debian/ifcico.postinst
--- ifmail-2.14tx8.10/debian/ifcico.postinst    2007-03-05 13:50:48.000000000 
+0100
+++ ifmail-2.14tx8.10-updateinted/debian/ifcico.postinst        2007-03-05 
14:34:06.000000000 +0100
@@ -1,9 +1,11 @@
 #!/bin/sh -e
 
-update-inetd --comment-chars "#disabled#" --disable tfido
-update-inetd --group OTHER --add "tfido                stream  tcp     nowait  
ftn     /usr/sbin/tcpd  /usr/lib/ifmail/ifcico -r 0 -t"
-update-inetd --comment-chars "#disabled#" --disable fido
-update-inetd --group OTHER --add "fido         stream  tcp     nowait  ftn     
/usr/sbin/tcpd  /usr/lib/ifmail/ifcico -r 0"
+if [ "$1" = "configure" ]; then
+  update-inetd --comment-chars "#disabled#" --disable tfido
+  update-inetd --group OTHER --add "tfido              stream  tcp     nowait  
ftn     /usr/sbin/tcpd  /usr/lib/ifmail/ifcico -r 0 -t"
+  update-inetd --comment-chars "#disabled#" --disable fido
+  update-inetd --group OTHER --add "fido               stream  tcp     nowait  
ftn     /usr/sbin/tcpd  /usr/lib/ifmail/ifcico -r 0"
+fi
 
 #DEBHELPER#
 
diff -uriNp ifmail-2.14tx8.10/debian/ifcico.postrm 
ifmail-2.14tx8.10-updateinted/debian/ifcico.postrm
--- ifmail-2.14tx8.10/debian/ifcico.postrm      2007-03-05 13:50:48.000000000 
+0100
+++ ifmail-2.14tx8.10-updateinted/debian/ifcico.postrm  2007-03-05 
14:22:09.000000000 +0100
@@ -1,10 +1,5 @@
 #!/bin/sh -e
 
-update-inetd --remove "^tfido"
-update-inetd --comment-chars "#disabled#" --enable tfido
-update-inetd --remove "^fido"
-update-inetd --comment-chars "#disabled#" --enable fido
-
 if [ "$1" = "purge" ]; then
   rm -rf /var/spool/ftn/nl.d/index.dir \
   /var/spool/ftn/nl.d/index.pag  >/dev/null
diff -uriNp ifmail-2.14tx8.10/debian/ifcico.prerm 
ifmail-2.14tx8.10-updateinted/debian/ifcico.prerm
--- ifmail-2.14tx8.10/debian/ifcico.prerm       1970-01-01 01:00:00.000000000 
+0100
+++ ifmail-2.14tx8.10-updateinted/debian/ifcico.prerm   2007-03-05 
14:22:27.000000000 +0100
@@ -0,0 +1,7 @@
+#!/bin/sh -e
+
+update-inetd --remove "^tfido"
+update-inetd --comment-chars "#disabled#" --enable tfido
+update-inetd --remove "^fido"
+update-inetd --comment-chars "#disabled#" --enable fido
+

Reply via email to