On 3/5/07, Miklos Szeredi <[EMAIL PROTECTED]> wrote:
> > Lowering severity to wishlist, as this is just an aesthetic problem,
> > isn't it?
> >
> > Will add a singing dancing LSB compatible init script to fuse-2.7
> >
> > Thanks,
> > Miklos
>
> As it is now, I thought that FUSE failed to start because it printed
> out an empty message after the "starting:" part.
>
> Now, it wont bother me because I know it does work. But it is going to
> confuse other people.
>
> So since it can actually be quickly changed to print a saner message
> (ignoring the format for LSB and other niceties), I think this would
> be a nice thing to have. This change would take fewer characters than
> was in your reply email :).

Sure, bit it would take 10 times more thinking, which is the real
bottleneck here ;)

Thanks,
Miklos


A simple patch to avoid calling log_end_msg twice.

Regards, Thue

--- fuse-utils.old      2007-03-05 20:21:02.000000000 +0100
+++ fuse-utils  2007-03-05 20:20:41.000000000 +0100
@@ -33,6 +33,7 @@
               if ! modprobe fuse >/dev/null 2>&1; then
                       log_failure_msg "Error: loading fuse module"
                       log_end_msg 1
+                       exit 1
               fi
       fi
       if grep -qw fusectl /proc/filesystems && \
@@ -40,6 +41,7 @@
               if ! mount -t fusectl none $MOUNTPOINT >/dev/null 2>&1; then
                       log_failure_msg "Error: mounting control filesystem"
                       log_end_msg 1
+                       exit 1
               fi
       fi
       log_end_msg 0
@@ -50,12 +52,14 @@
               if ! umount $MOUNTPOINT >/dev/null 2>&1; then
                       log_failure_msg "Error: unmounting control filesystem"
                       log_end_msg 1
+                       exit 1
               fi
       fi
       if grep -qw "^fuse" /proc/modules; then
               if ! rmmod fuse >/dev/null 2>&1; then
                       log_failure_msg "Error: unloading fuse module"
                       log_end_msg 1
+                       exit 1
               fi
       fi
       log_end_msg 0


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to