On Wed, Mar 07, 2007 at 09:59:19AM +0000, Philip Armstrong wrote:
>
> Those if(probe.thingy) guards are entirely redundant: free(p) is a
> no-op if p is NULL.
I didn't use that particular patch, but one that uses a goto into the
standard function exit/cleanup path.
However, e2fsprogs is still mostly written in a pre-C99 style, because
there are systems where free() will fail or crash if passed the NULL
pointer. (I'll note that the gdb coding standards still requires the
use of xfree(), which does the null pointer check because of this
concession to pragmatics.) So Steinar simply wrote the patch in the
style of the surrounding code, which is a Good Thing.
Regards,
- Ted
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
