Christian Perrier wrote: > Package: dtc > Version: N/A > Severity: normal > Tags: patch > > Dear Debian maintainer, > > On 08 Mar 2007, I notified you of the beginning of a review process > concerning debconf templates for dtc. > > The debian-l10n-english contributors have now reviewed these templates, > and the proposed changes are attached to this bug report. > > Please review the suggested changes are suggested, and if you have any > objections, let me know in the next 3 days. > > Please try to avoid uploading dtc with these changes right now. > > The second phase of this process will begin on 20 Mar 2007, when I will > coordinate updates to translations of debconf templates. > > The existing translators will be notified of the changes: they will > receive an updated PO file for their language. > > Simultaneously, a general call for new translations will be sent to > the debian-i18n mailing list. > > Both these calls for translations will request updates to be sent as > individual bug reports. That will probably trigger a lot of bug > reports against your package, but these should be easier to deal with. > > The call for translation updates and new translations will run until > 01 Apr 2007. Please avoid uploading a package with fixed or changed > debconf templates and/or translation updates in the meantime. Of > course, other changes are safe. > > On 02 Apr 2007, I will contact you again and will send a final patch > summarizing all the updates (changes to debconf templates, > updates to debconf translations and new debconf translations). > > Again, thanks for your attention and cooperation.
Christian, First of all, I want to thank you a lot for your work. It's is appreciated a lot, and I am very happy that my bad english is corrected. Here are my remarks on this patch. - Please note that apache's standard installation setup /var/www as the - apache web area (document root). Remove this manually in your - /etc/apache/httpd.conf (or in /etc/apache2) if you choose /var/www/sites - as DTC's hosting area. + The default Apache installation defines /var/www as the document + root. This should be removed from the httpd.conf file manually when + another directory is chosen as DTC's hosting area. You are changing the meaning of it. The purpose of this was to tell that the default DocumentRoot should NOT be pointing to /var/www if using this path, as this could reveal all the files. By the way, on the current setup, this is not true anymore. DTC takes over the apache config, but maybe, to be 100% sure there is no security issue, best would be to just write something like this: If you choose the default of /var/www, make sure that no DocumentRoot is pointing to this path, so there is no chance to publicly give access to all your hosted files. -_Description: Path where to build the chroot environment: - Please enter the path where you want DTC to build the cgi-bin chroot +_Description: Path for the chroot environment: + Please enter the directory to be used by DTC to build the cgi-bin chroot I'd like to insist a bit more on the fact this is a template copied on each subdomain. Maybe it's better to write: +_Description: Path for the chroot environment template: This one now: - Note that in the case of a dynamic IP address, using NAT and port forwarding - is the only way to use DTC (because apache vhost file wont need to be - regenerated at each IP change). + Do not choose this option if the server is directly connected to the + Internet, except when using dynamic IP addresses. In such cases, NAT + and port forwarding are mandatory for DTC. Reading it, it seems a bit strange, as the server can't be both connected directly to internet with a public IP, and have NAT. Maybe we should write this: + Do not choose this option if the server is directly connected to the + Internet. If your internet connection is delivered by a dynamic IP addresses, choosing this option is mandatory. You then have to use a firwall doing NAT between your server and the internet, and use port forwarding to your server. The rest of seems fine to me, better, quicker to read, with the same meaning. Nice job! Thomas -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
