On Wednesday 28 March 2007 00:35, Alex Owen wrote: > I know this is very late in the release cycle but I would like to see > this rewrite of grub_serial_console enter d-i for Etch.
No, sorry. This issue is too minor to run the risk of regressions.
I spotted a few serious issues with the new version for
grub_serial_console in the following two lines:
[ $word ] && local word="--word=$word"
[ $speed ] || local speed=9600 #Match Kernel Default
- In the tests the variables need to be quoted to avoid a syntax error
when they are empty.
- As the script is run with 'set -e' the first line will cause the
script to abort when the variable is empty as there is no "||".
In both cases it would be better to use real if/then statements.
Cheers,
FJP
pgpbHZlWGO3fi.pgp
Description: PGP signature
