* Andreas Jochens ([EMAIL PROTECTED]) wrote: > Hello, > > thank you for your reply to my bug report. > > On 05-Apr-01 00:15, Eric Dorland wrote: > > Thanks for the patch, but a few things look funny to me. Especially > > going from a PRUint32 to a long. Can you maybe report this upstream > > (bugzilla.mozilla.org) and see what they have to say? > > The problem is that gcc-4.0 does not accept a conversion from a > pointer to a 32 bit intereger type on 64 bit architectures.
Indeed, it's good that it doesn't accept those.
> The patch which changes 'PRUint32(param)' to 'long(param)' looks
> quite innocent to me:
It's not wrong, it's just I think the mozilla developers have their
own typedefs they would rather have used.
> > > diff -urN
> > > ../tmp-orig/mozilla-firefox-1.0.1/netwerk/protocol/http/src/nsHttpConnectionMgr.cpp
> > > ./netwerk/protocol/http/src/nsHttpConnectionMgr.cpp
> > > ---
> > > ../tmp-orig/mozilla-firefox-1.0.1/netwerk/protocol/http/src/nsHttpConnectionMgr.cpp
> > > 2004-09-02 01:31:03.000000000 +0200
> > > +++ ./netwerk/protocol/http/src/nsHttpConnectionMgr.cpp 2005-03-22
> > > 13:27:34.000000000 +0100
> > > @@ -834,8 +834,8 @@
> > > void
> > > nsHttpConnectionMgr::OnMsgUpdateParam(nsresult status, void *param)
> > > {
> > > - PRUint16 name = (PRUint32(param) & 0xFFFF0000) >> 16;
> > > - PRUint16 value = PRUint32(param) & 0x0000FFFF;
> > > + PRUint16 name = (long(param) & 0xFFFF0000) >> 16;
> > > + PRUint16 value = long(param) & 0x0000FFFF;
> > >
> > > switch (name) {
> > > case MAX_CONNECTIONS:
>
> Only the lower 32 bits are used here anyway. I do not see why this
> should cause any problems. But I can of course try to discuss this with
> upstream.
Please do file a bugzilla bug, and make a note of it in the debian
bug. If you need me to file it upstream, let me know.
--
Eric Dorland <[EMAIL PROTECTED]>
ICQ: #61138586, Jabber: [EMAIL PROTECTED]
1024D/16D970C6 097C 4861 9934 27A0 8E1C 2B0A 61E9 8ECF 16D9 70C6
-----BEGIN GEEK CODE BLOCK-----
Version: 3.12
GCS d- s++: a-- C+++ UL+++ P++ L++ E++ W++ N+ o K- w+
O? M++ V-- PS+ PE Y+ PGP++ t++ 5++ X+ R tv++ b+++ DI+ D+
G e h! r- y+
------END GEEK CODE BLOCK------
signature.asc
Description: Digital signature
