Package: sig2dot
Severity: wishlist

Christoph
-- 
[EMAIL PROTECTED] | http://www.df7cb.de/
--- Begin Message ---
Hi,

I sent a patch for sig2dot to Kevin a few weeks ago, but I see that you
are the new maintainer of this package.
My patch fixed the problem with the new version of gpg (you already
fixed it) and proposed some improvements:
- removes the comments of the uid (usually they are quite boring, and
  do not mean anything since it is different for each uid)
- if using
        $ gpg --list-sigs "some_special_pattern" | sigdot -a
  which is quite usefull to get a graph from special part of your
  keyring, it removes the uid from extern users (which is already done
  when you are not using the "-a").
I attach to this mail the reduced patch, please check it and include it
if there is no problems.

Please note 2 things:
- the [user id not found] is never used with this patch, so you can
  remove everything linked to this from the script
- there is some internationalization problems with the "revoked" text
  (in French, for example, it is "r'evoqu'e")

Regards,

-- 
Thomas Huriaux
--- /usr/bin/sig2dot    2005-03-06 20:53:06.000000000 +0100
+++ sig2dot     2005-03-08 10:45:37.336302261 +0100
@@ -135,9 +135,12 @@
       {
         $id = (split('/',$id))[1];
         $owner = $id; 
+        if ($all and not $name =~ /^\[revoked/) {
+         push (@idlist, $id, $owner);
+        }
       } 
   
-      $name{$id} = $name if $name; # gpg 1.4 fixup
+      $name{$id} = (split('\(',$name))[0] if $name; # gpg 1.4 fixup
   
       # skip revoked keys 
       if ($name =~ /^\[revoked/) {
@@ -258,6 +261,15 @@
   if (($sigcount{$id} eq "") and ($signedbycount{$id} eq "") and not $all) {
     next;
   }
+  if ($all) {
+    $used_id = 0;
+    for $owner (@idlist) {
+      if ($owner eq $id) {
+        $used_id = 1;
+      }
+    }
+  }
+  next if ($all and $used_id == 0);
   if ($color)
   {
     $red = $sigcount{$id} / $maxsigcount;

Attachment: signature.asc
Description: Digital signature


--- End Message ---

Attachment: signature.asc
Description: Digital signature

Reply via email to