Package: gcin
Version: 1.3.4-2
Severity: important

        Hi,

 While looking over the changes you did for the Gtk 2.10 transition
 (thanks for taking care of it so quickly BTW!), I noticed you hardcode:
    GTKVER = 2.10.0
 this is risky, as this might break silently with the next Gtk binary
 change and the idea of the binver was to handle such changes
 transparently.

 You want to use "pkg-config --variable=gtk_binary_version gtk+-2.0"
 (and build-depend on pkg-config) instead of using the hardcoded
 version:
    GTKVER = $(shell pkg-config --variable=gtk_binary_version gtk+-2.0)

   Bye,
-- 
Loïc Minier

Reply via email to