-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Loïc Minier wrote:
> Package: svn-buildpackage
> Version: 0.6.18
> Severity: normal
>
> Hi,
Hi Loïc,
> I get this warning when a build fails:
> -> policy-rc.d already exists
> -> Cleaning COW directory
>
> Use of uninitialized value in concatenation (.) or string at
> /usr/share/svn-buildpackage/SDCommon.pm line 74 (#2)
Line 74 is this:
print STDERR "Command $cmd failed in ".Cwd::getcwd.", how to
continue now? [Qri?]: ";
> Command /bin/sh -c my-pdebuild failed in , how to continue now? [Qri?]:
Judging from the missing directory name ^^^^^^^^^
and from the fact you used COW, I suspect the build directory is
removed before this message appears making the Cwd::getcwd command fail.
I am not that sure the attached patch fixes the issue, so I am not
committing it. I would also like Edi to comment on this patch since
I am really not sure of my patch and approach.
- --
Regards,
EddyP
=============================================
"Imagination is more important than knowledge" A.Einstein
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFGIqOeY8Chqv3NRNoRAmO0AKCpmNDV1HxWAAUXng5hvsm0YUJYGACffTAD
J6OkcMgdGiuiNUOd16lSHIg=
=qw0M
-----END PGP SIGNATURE-----
Index: SDCommon.pm
===================================================================
--- SDCommon.pm (revision 3072)
+++ SDCommon.pm (working copy)
@@ -71,7 +71,9 @@
retry:
print STDERR "$cmd\n" if(!$SDCommon::opt_quiet);
if(system(@_)) {
- print STDERR "Command $cmd failed in ".Cwd::getcwd.", how to continue now? [Qri?]: ";
+ my $cdir = Cwd::getcwd ;
+ $cdir = "<unknown>" unless ($cdir);
+ print STDERR "Command $cmd failed in ".$cdir.", how to continue now? [Qri?]: ";
prompt:
my $ans = <STDIN>;
if($ans =~ /^q$/i or $ans =~ /^$/) {
