On Sun, 8 Apr 2007, Peter Rabbitson wrote:

> Package: dstat
> Version: 0.6.3-2
> Severity: important
> Tags: patch
> 
> 
> Dstat incorrectly adds the value from /proc/meminfo/SwapCached to the value
> of Cached, resulting in skews of _used and _cach when running dstat with the
> -m flag. In a discussion two months ago 
> (http://lists.rpmforge.net/pipermail/tools/2007-February/000714.html)
> the author acknowledged that this is a problem, but no changes were ever 
> commited to the svn repository since. Hence I am filing a bug here, so at
> least the Debian version of dstat can be permanently fixed. The fix is a 
> simple one liner:
> 
> =begin patch
> --- /usr/bin/dstat.org  2006-06-26 02:04:04.000000000 +0200
> +++ /usr/bin/dstat      2007-04-08 12:48:01.000000000 +0200
> @@ -974,5 +974,4 @@
>                         if name in self.vars + ('MemTotal', 'SwapCached'):
>                                 self.val[name] = long(l[1]) * 1024.0
> -               self.val['Cached'] = self.val['Cached'] + 
> self.val['SwapCached']
>                 self.val['MemUsed'] = self.val['MemTotal'] - 
> self.val['MemFree'] - self.val['Buffers'] - self.val['Cached']
> 
> =end patch

Sorry for having missed this. It clearly shows the Debian bug tracking 
system works :)

I have now added your patch to subversion, sadly I made a release 
yesterday that doesn't have the patch included. (note to self: Never do a 
release without cathing up on email after a holiday)

Kind regards,
--   dag wieers,  [EMAIL PROTECTED],  http://dag.wieers.com/   --
[all I want is a warm bed and a kind word and unlimited power]


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to