This one time, at band camp, Nigel Horne said:
> 
> 
> > -----Original Message-----
> > From: Stephen Gran [mailto:[EMAIL PROTECTED]
> > Sent: 19 April 2007 11:01
> 
> > Try this patch:
> 
> A better patch would be to remove the - from this line, since
> clamav-milter already does that for you.
> 
> -      kill -15 -"$PID" 2>/dev/null || true
> +      kill -15 $PID 2>/dev/null || true

The point of doing it the other way is that there is currently a bug in
one of the lsb init routines that deletes the pid file in the wrong
circumstances.  If there is no pid file, the pid discovery routines
effectively end up calling pidof, which does not return the pid prefixed
with a '-'.  Until the lsb init routine bug is fixed, I think the
original patch makes more sense.  But, generally speaking, yes, your way
is cleaner.
-- 
 -----------------------------------------------------------------
|   ,''`.                                            Stephen Gran |
|  : :' :                                        [EMAIL PROTECTED] |
|  `. `'                        Debian user, admin, and developer |
|    `-                                     http://www.debian.org |
 -----------------------------------------------------------------

Attachment: signature.asc
Description: Digital signature

Reply via email to