David Schmitt <[EMAIL PROTECTED]> wrote:

> The "overwwrites local config" part is way harder. Looking at the postinst
> gives me the creeps. 

I've found one more.  This script would be much better readable if it
wouldn't use the same code over and over, without any shell function -
I found at least one cut&paste error:

if [ "$USE_PPP" = "true" ]; then
    if grep '^ppp' $OPTIONS >/dev/null 2>&1 ; then
        : # already there
    else
        safe_edit_file $OPTIONS perl -e 's/^(\s*ppp)/# $1/'
        echo ppp >> $OPTIONS
    fi
elif [ "$USE_HTDIG" = "false" ]; then
    safe_edit_file $OPTIONS perl -e  's/^(\s*ppp)/# $1/'
else
    : # don't touch the existing settings
fi

In the elif line, this must be $USE_PPP, of course.

Regards, Frank
-- 
Frank Küster
Inst. f. Biochemie der Univ. Zürich
Debian Developer


Reply via email to