tag 414745 patch thanks On Thu, Apr 19, 2007 at 06:43:25PM +0200, Lucas Nussbaum wrote:
> # Failed test 'Select OK' > # in t/01.t at line 43. > # got: '<select name="bar"><option value="1">Hi</option></select> > # ' > # expected: '<select name="bar"><option value=1>Hi</option></select> > # ' The test failures are due to two changes in HTML::Tree introduced in upstream 3.19_02: * Non-closing HTML tags like <IMG> are now rendered as <IMG />. * All values in tags are now double-quoted. Previously, all-numeric values weren't quoted. The changes entered Debian in libhtml-tree-perl 3.23-1. This is also CPAN #19802, http://rt.cpan.org/Public/Bug/Display.html?id=19802 I'm attaching a proposed patch that adapts the tests to the new HTML::Tree behaviour and declares a versioned build-dependency accordingly. Cheers, -- Niko Tyni [EMAIL PROTECTED]
diff -u libclass-dbi-asform-perl-2.42/debian/control libclass-dbi-asform-perl-2.42/debian/control --- libclass-dbi-asform-perl-2.42/debian/control +++ libclass-dbi-asform-perl-2.42/debian/control @@ -3,7 +3,7 @@ Priority: optional Maintainer: Bart Martens <[EMAIL PROTECTED]> Build-Depends: cdbs, debhelper (>= 5) -Build-Depends-Indep: perl (>= 5.6.0-16), libhtml-tree-perl, libclass-dbi-perl (>= 0.94), libclass-dbi-plugin-type-perl, libdbi-perl (>= 1.21), libdbd-sqlite3-perl, libtest-pod-perl, libtest-pod-coverage-perl +Build-Depends-Indep: perl (>= 5.6.0-16), libhtml-tree-perl (>= 3.23-1), libclass-dbi-perl (>= 0.94), libclass-dbi-plugin-type-perl, libdbi-perl (>= 1.21), libdbd-sqlite3-perl, libtest-pod-perl, libtest-pod-coverage-perl Standards-Version: 3.7.2 Package: libclass-dbi-asform-perl only in patch2: unchanged: --- libclass-dbi-asform-perl-2.42.orig/t/01.t +++ libclass-dbi-asform-perl-2.42/t/01.t @@ -40,15 +40,15 @@ "Ordinary text field OK"); Foo->has_a(bar => Bar); -is(Foo->to_field("bar"), "<select name=\"bar\"><option value=1>Hi</option></select>\n", +is(Foo->to_field("bar"), "<select name=\"bar\"><option value=\"1\">Hi</option></select>\n", "Select OK"); my $x = bless({id => 1, bar => Bar->retrieve_all(), baz => "Hello there"}, "Foo"); -my %cgi = ( id => '<input name="id" type="text" value=1> +my %cgi = ( id => '<input name="id" type="text" value="1" /> ', - bar => '<select name="bar"><option selected value=1>Hi</option></select> + bar => '<select name="bar"><option selected value="1">Hi</option></select> ', - baz => '<input name="baz" type="text" value="Hello there"> + baz => '<input name="baz" type="text" value="Hello there" /> ' ); is_deeply({$x->to_cgi}, \%cgi, "All correct as an object method");