On Fri, Apr 27, 2007 at 11:34:02PM +0200, Loïc Minier wrote: > On Fri, Apr 27, 2007, Ming Hua wrote: > > I've fixed the hardcoding GTK IM module path bug in scim, based on the > > patch you sent. I used @GTK_BINARY_VERSION@ instead of > > $(GTK_BINARY_VERSION) as your patch did. From my understanding, these > > two should be functionally identical for automake, I am using the former > > only to be consistent with upstream's style. > > Yes; I've seen the heavy use of @@ vars in their Makefile.am. FYI, > this is not a good idea, especially for directories: it's recommended > to use $() in order to be able to override values during various make > invocation, for example: > make install prefix=/opt/... bindir=/foobar/... > > This is less useful for the GTK_BINARY_VERSION obviously, but it's > recommended to use $() instead of @@ for the above reason.
Interesting discussion... > > I've attached the patch (SVN change r842), excluding the > > machine-generated relibtoolization patch, in case you or anyone else > > want to have a look. > > The new package should be uploaded soon when my sponsor have time. > > Looked good; thanks. I uploaded it as Ming provided and it should close this bug report by the changelog. Osamu
signature.asc
Description: Digital signature
