On Thu, May 10, 2007 at 10:47:29PM +0200, Petter Reinholdtsen wrote:
[David Härdeman]
Here's a more complete stub (/lib/init/splash-functions-base) file which should allow many more scripts to use the generic functions.

This API looks quite good, and I suspect it will handle most needs.
We might need some splash_start_if_not_running() or similar, for the
cases where it need to be restarted.

splash_start would perhaps be enough, that it's a NOP if a splash is already running is implicit :)

Also, this function need to have more features:

# Tells the splash the current boot progress in percent (as $1)
splash_progress () { return 0; }

In usplash, the progress bar can go both ways, depending on the sign
of the progress value.  It is used during shutdown.  We probably want
to support it in the API.

Yes, should be enough to add one more line stating that shutdown progress is defined as negative percent values?

Also, to stay compatible with the current behaviour, I suspect the
default functions should implement usplash support until usplash
includes the override file in the package.

Even if we synchronize the uploads of a fixed usplash and sysvinit?

usplash is a bit broken right now with the integration with different boot scripts so I'm not sure it's necessary...

--
David Härdeman


Reply via email to