intrigeri wrote (18 Jan 2007 23:21:28 GMT) : > The Anarcat wrote (10 Jan 2007 17:53:13 GMT) : >> I did some work to get there. I have attached a patch that adds a >> "protocol" option, that, if unset defaults to scp. > > Thanks for this patch, which I'd like to apply upstream once it's > documented, added to example.dup, and dealt with by ninjahelper ; > I won't do this myself, but I can offer help to : > - take care of the remote setup tests ; > - review your patch next versions, as I'm doing for this one. > >> It's not quite clean yet, because it lacks documentation and it's >> really just a flag right now. Not sure what would happen if you'd >> enter, say, "ssh" or (!) "ftp" as a protocol. :) Maybe backupninja >> should check for this... > > Yes, I think it's necessary to test if the protocol option has a valid > value, and exit with an error if this is not the case : this would at > least unveil some typos in configuration files... e.g. if I wrote > "protocol = fole", I would like to be informed of it in clear terms, > and not simply by seeing that a scp connection I did not expect to > happen failed. > >> I also haven't tested what happens if you *don't* enter a protocol (or >> put "scp"). I guess it will behave fine, but I don't have a remote >> setup to do formal testing. > > The test I recommend above would also cover this case, IMHO.
Any news from this, Anarcat ? Ciao, -- intrigeri <[EMAIL PROTECTED]> | gnupg key @ http://intrigeri.boum.org/intrigeri.asc | We're dreaming of something else. | Something more clandestine, something happier. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
