Package: tipptrainer
Version: 0.6.0-1
Severity: important
Tags: upstream

The upstream Makefile does not check for errors appropriately, as it does
things like this:

all:
        for i in src po; do \
            $(MAKE) -C $$i all; \
        done

which means errors in "make -C src all" will be hidden by a sucessfull
run of "make -C po all".

This is very bad, as there might be some error in the compiler or the
linker that makes the executable not to be created, but the package
would be created anyway (maybe without any executable at /usr/bin).

To reproduce, change the last line of src/Makefile.in so that it reads:

$(BINARY): $(OBJECTS)
        false

This will simulate a broken linker, but the package will be created
anyway and will have nothing in /usr/bin.


To fix this, I suggest that every "for" is replaced by sequential calls
to $(MAKE), like this:

all:
        $(MAKE) -C src all
        $(MAKE) -C po all


 Thanks.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to