On Fri, Jun 29, 2007 at 11:16:46PM -0400, A. Costa wrote: > In lines #177898-9 the phrase "so no further processing was performed" > to me suggests a relatively brief list of errors. Also the old error > message's count would have been more useful, if it worked. A feature > was amputated to fix this bug.
Unfortunately, the way the code works is that it uses the XML::LibXML library to perform the initial validation of the file. This library doesn't provide a nice interface to the list of errors, it just returns the string containing the error messages output to the user. It would be possible to parse this string to provide the summary output, but it wouldn't be a particularly clean solution as it would be relying on the format of these errors staying the same. An ideal solution would be to improve the interface to XML::LibXML to provide a better interface to these error messages. I haven't yet had chance to look at this module and investigate how easy this would be to provide. > at /usr/share/perl5/XMLTV/ValidateFile.pm line 146 > > Summary of errors. total 59298 > ================================================= > Couldn't find end of Start Tag episode-num 19231 > Couldn't find end of Start Tag length 535 > attributes construct error 19766 > error parsing attribute name 19766 > > The file did not validate as well-formed XML, so no further > processing was performed. > > ...this would put "no further" in a clear context. > > I'm unsure whether to reopen this bug, or to leave it closed and file > a new 'wishlist' bug. Please advise. I think this summary output would be useful. However I think, as you suggested, it should be a new wishlist item against the package, and possibly an associated wishlist item against libxml-libxml-perl about the lack of decent error reporting. -- Chris Butler <[EMAIL PROTECTED]> GnuPG Key ID: 1024D/D097A261
signature.asc
Description: Digital signature
