Package: sshfs
Version: 1.6-1
Tags: patch
Followup-For: Bug #430225

Despite of debatable usefulness of some ssh_config options with sshfs,
this is a general problem. The list of recognized ssh_config options is
hardcoded in sshfs.c and, sooner or later, this will prevent legitimate
use. I ran into this when trying to disable connection sharing ad hoc,
using ControlPath=none, for debugging another problem.

There are two possible solutions:

 1. Regularly add new ssh_config options to sshfs.c (or at least add one
    at a time after each reasoned, acceptable request ;).

 2. Add a more general syntax to pass ssh_config options to ssh (or even
    to pass any options to ssh, but this seemed unnecessary to me).

I've implemented both. Solution 1 is attached as more_ssh_options.patch
(only using options that seemed of possible utility with sshfs; this
didn't include ForwardAgent, when I went through ssh_config(5)).

Number 2 is all_ssh_options.patch. This adds "-o ssh_opt_SSHOPT=VALUE",
for any SSHOPT. If the user should choose an invalid one, sshfs will
silently exit with code 141; but it will likewise when, e.g.,
"-o Port=jkalsd34jk" (or something less obviously erroneous) is fed to
the unpatched version.

Please review and possible include the patches in your next upload.

Regards, Fabian

-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-4-686
Locale: LANG=de_DE, LC_CTYPE=de_DE (charmap=ISO-8859-1)

Versions of packages sshfs depends on:
ii  fuse-utils                  2.5.3-4.4    Filesystem in USErspace (utilities
ii  libc6                       2.3.6.ds1-13 GNU C Library: Shared libraries
ii  libfuse2                    2.5.3-4.4    Filesystem in USErspace library
ii  libglib2.0-0                2.12.4-2     The GLib library of C routines

sshfs recommends no packages.

-- no debconf information

Attachment: more_ssh_options.patch
Description: application/not-regular-file

Attachment: all_ssh_options.patch
Description: application/not-regular-file

Reply via email to