When looking over your checks I found a serious issue: Encoding is *not* a deprecated key! Please read appendix d of the spec.
You should further add a test for the ending semicolon of the MimeType and the Categories field (if not empty). Then, what is desktop-icon-not-in-xpm-format used for? There is no recommendation nor requrement for an XPM icon. It is recommended to supply the icon name without the path and without an extension. desktop-icon-missing is also useless, because there is no requirement, the icon must be there. The icon could be part of a theme, that is currently not installed. When I say theme, you also see, that checking /usr/share/pixmaps is useless. And forcing the user to install all themes just to check if any contains the icon, is a bad idea. Ditto for desktop-icon-too-big. Themese can supply the icon in any size or as scalable vector graphics. IMHO useless test too. IMHO the only test you could do here is, if the icon name follows the recommendation: Check if it uses a path and check if it contains an extension and throw warnings in these cases. Another nice check would be, if the encoding of the file is correct. This test would need two parts: 1) Test if the given value of the Encoding key fits the encoding of the file. 2) If no Encoding key is given, check if the encoding of the file is UTF-8. Some other tests (could be done in the the future if seen as useful): Check for X11/GTK/GNOME/QT/KDE/Motif/Java dependencies and complain if the Categories key does not contain the related category. Regards, Daniel -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
