On Sunday 19 August 2007 05:18:16 am Guido Guenther wrote: > I do see your point but think that a) will cause more harm than it does > good (people trying to including git meta data into packges, failed > builds because of that, ...) and thought b) would be overkill, although > I'm open to suggestions here.
how about providing a cmdline flag like --git-no-filter then? it would mean a difference of like 5 or 6 lines of code. > The manual has explanations for running with pbuilder. the problem with that is it prevents passing additional arguments to pbuilder, as well as prevents using yet other builders. for example, i have a wrapper script that implements multiple different versions of pbuilder via symlinks: pbuilder-sid-i386, pbuilder-sid-amd64, pbuilder-etch, etc. the amount of work required to support all these different variations would be far more than simply adding a cmdline switch. really, i think the "Right Thing" would be to have --git-builder not default to "debuild", but instead "debuild -i.git -I.git", thus not requiring the kludge of adding in the options as an afterthought, and rather explicitly spelling otu to anyone who wanted to change the config that they might want something similar. but if that's not acceptable to you, i think the additional flag would work for me. sean
signature.asc
Description: This is a digitally signed message part.