tags 438849 upstream moreinfo stop Hi Uwe,
Uwe Hermann <[EMAIL PROTECTED]> writes: > On Mon, Aug 20, 2007 at 02:23:20PM +0100, Darren Salt wrote: >> > Uwe Hermann <[EMAIL PROTECTED]> writes: >> >> here's a patch which fixes the xine build on Debian GNU/kFreeBSD. >> >> > Thanks for the patch, Uwe! I'm forwarding it to the xine developers, so >> > it can be included in the next release. >> [snip patch] >> >> Why is only the vcd input plugin patched? Why not other files which check for >> __FreeBSD__? > > Good question. For me it was enough to be able to build the Debian > package, but I guess we should fix all files... > > >> Would it be better to have include/config.h cause __FreeBSD__ to >> be defined if __FreeBSD_kernel__ is defined? > > Yes, I think that should work, but I haven't tested anything, yet. I feel very uncomfortable with supporting a patch which has been rejected upstream. Could you perhaps try to improve the patch by following Darren's suggestions, and resubmit it to [EMAIL PROTECTED] (CC'ing this bug). -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
